publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
957 stars 1.83k forks source link

DISCUSSION: topic boxes on profile pages via automatic subscriptions upon signup? #6220

Closed ebarry closed 5 years ago

ebarry commented 5 years ago

Hello!!! šŸŒ³šŸŒ³šŸŒ³šŸŒ³šŸŒ³šŸŒ³šŸŒ³šŸŒ³

I would like to open a discussion with an observation that i had after reviewing dozens of new profiles pages registered on PublicLab.org as part of my activities to moderate first-time-poster content. This is an adjacent issue to https://github.com/publiclab/plots2/issues/6219 about the duplicate topic boxes.

On the profile page of someone who has contributed only once, i would not expect to see any topic boxes yet. šŸŒ³ However, i believe that i am seeing new profile pages that already have many, many topic boxes of a variety of our biggest topics -- balloon-mapping, spectrometry, newsletter. (see https://github.com/publiclab/plots2/issues/6219)

I would like to use this issue to discuss the assumptions made about the "automatic subscriptions upon signup" that i think -- although i'm not sure -- are generating these topic boxes that appear on profile pages. šŸ˜®

Something to consider: If i were a new member myself šŸ‘©ā€šŸŽØ, it is quite possible that i would become irritated that spectrometry was showing up all over my profile page for the following reasons

  1. this is not my interest
  2. i don't want to be represented this way publicly
  3. i specifically don't want to be subscribed to spectrometry

Specifically regarding the newsletter tag, i have a couple @jywarren questions :) --

Automatically subscribing people to the /newsletter tag could be useful if we were in fact posting our monthly newsletter as research notes to the website. Are we? I don't think we are but i'd like to discover that we are!

Or perhaps an automatic subscription to the newsletter tag adds people to our newsletter recipient list in Campaign Monitor? I do not think this is happening, but i'd be excited to discover that it was!

I am interested in hearing your thoughts on the above. thanks!

jywarren commented 5 years ago

Hi, actually the auto-subscriptions haven't been implemented yet, and what you are seeing on new profiles is the result of some very old code, that fills in the following tags if you have no tags on any posts (and/or no posts):

tagnames += ['balloon-mapping', 'spectrometer', 'near-infrared-camera',

'thermal-photography', 'newsletter'] if tagnames.empty? && defaults

https://github.com/publiclab/plots2/blob/d4d69ab4144d1457749ff215c53b63e167cc7142/app/models/user.rb#L157

So this is an unintended consequence.

The later-on plan of auto-subscribing people was roughly intended to include 5 or so "top topics" and we had assumed air-quality, water-quality, and a few other top ones from our featured topics (list now in the footer). Def. we want to get input on which should be auto-subscribed, but we haven't implemented that yet.

On Wed, Aug 28, 2019 at 4:35 PM Liz Barry notifications@github.com wrote:

Hello!!! šŸŒ³šŸŒ³šŸŒ³šŸŒ³šŸŒ³šŸŒ³šŸŒ³šŸŒ³

I would like to open a discussion with an observation that i had after reviewing dozens of new profiles pages registered on PublicLab.org as part of my activities to moderate first-time-poster content. This is an adjacent issue to #6219 https://github.com/publiclab/plots2/issues/6219 about the duplicate topic boxes.

On the profile page of someone who has contributed only once, i would not expect to see any topic boxes yet. šŸŒ³ However, i believe that i am seeing new profile pages that already have many, many topic boxes of a variety of our biggest topics -- balloon-mapping, spectrometry, newsletter. (see

6219 https://github.com/publiclab/plots2/issues/6219)

I would like to use this issue to discuss the assumptions made about the "automatic subscriptions upon signup" that i think -- although i'm not sure -- are generating these topic boxes that appear on profile pages. šŸ˜®

Something to consider: If i were a new member myself šŸ‘©ā€šŸŽØ, it is quite possible that i would become irritated that spectrometry was showing up all over my profile page for the following reasons

  1. this is not my interest
  2. i don't want to be represented this way publicly
  3. i specifically don't want to be subscribed to spectrometry

Specifically regarding the newsletter tag, i have a couple @jywarren https://github.com/jywarren questions :) --

Automatically subscribing people to the /newsletter tag could be useful if we were in fact posting our monthly newsletter as research notes to the website. Are we? I don't think we are but i'd like to discover that we are!

Or perhaps an automatic subscription to the newsletter tag adds people to our newsletter recipient list in Campaign Monitor? I do not think this is happening, but i'd be excited to discover that it was!

I am interested in hearing your thoughts on the above. thanks!

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6220?email_source=notifications&email_token=AAAF6J3GEMYFTJWKHKYJKO3QG3ONNA5CNFSM4IRSS6G2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIA3MPQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JZFTMIDJF5XL6YJ5DTQG3ONNANCNFSM4IRSS6GQ .

ebarry commented 5 years ago

oh this is wonderful news! Is there a short term solution where we delete this old code, or would that break more than it fixes?

jywarren commented 5 years ago

Can we think of any reason we'd want to substitute other "backup" tags for any purpose? If not, we can simply remove that line and this should resolve itself. Thanks!

On Wed, Aug 28, 2019 at 5:11 PM Liz Barry notifications@github.com wrote:

oh this is wonderful news! Is there a short term solution where we delete this old code, or does that break more than it fixes?

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6220?email_source=notifications&email_token=AAAF6JZYFKJGG3VEPJQEZNLQG3SXLA5CNFSM4IRSS6G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MPPMY#issuecomment-525924275, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J6RHRT6AWGRYUPY4SLQG3SXLANCNFSM4IRSS6GQ .

ebarry commented 5 years ago

If the backup tags do not equal a subscription, then i can't think of any reason right now. I suppose without them, profile pages might look blank, but i think that's preferable. We could just have a message saying "please scroll down to the footer to see some topics you could subscribe to" or something like that

jywarren commented 5 years ago

Well, wait, the profile is not showing subscribed-to topics, but topics within which the author has posted. So if the author hasn't posted anything that has been tagged, we could show text like:

This person has not posted under any topics (linking to /tags).

We should consider a way to view any untagged posts they may have. I'm not sure about this, but we could consider something like a /notes/AUTHORNAME route that simply shows a list.

On Wed, Aug 28, 2019 at 5:32 PM Liz Barry notifications@github.com wrote:

If the backup tags do not equal a subscription, then i can't think of any reason right now. I suppose without them, profile pages might look blank, but i think that's preferable. We could just have a message saying "please scroll down to the footer to see some topics you could subscribe to" or something like that

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6220?email_source=notifications&email_token=AAAF6J3AZQPCPQSSGOD4HPTQG3VGBA5CNFSM4IRSS6G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MRELA#issuecomment-525931052, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J2HCXL525GHEPQ7WN3QG3VGBANCNFSM4IRSS6GQ .

ebarry commented 5 years ago

So perhaps the proposal here is to

?

jywarren commented 5 years ago

Yes, this sounds right!

On Thu, Aug 29, 2019 at 1:21 PM Liz Barry notifications@github.com wrote:

So perhaps the proposal here is to

  • remove the very old code, that fills in the following tags if you have no tags on any posts (and/or no posts): tagnames += ['balloon-mapping', 'spectrometer', 'near-infrared-camera', 'thermal-photography', 'newsletter'] if tagnames.empty? && defaults https://github.com/publiclab/plots2/blob/d4d69ab4144d1457749ff215c53b63e167cc7142/app/models/user.rb#L157
  • For those who have not posted any tagged content, consider adding something like a /notes/AUTHORNAME route that simply shows a list on their content on their profile.

?

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/6220?email_source=notifications&email_token=AAAF6J2XR4MJ5A3CWJSR643QHAARBA5CNFSM4IRSS6G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5PGXVA#issuecomment-526281684, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J6NQLJM6X27LN2P2PDQHAARBANCNFSM4IRSS6GQ .

jywarren commented 5 years ago

And linking the /notes/authorname route to the new issue opened in #6253 !

jywarren commented 5 years ago

OK, closing in favor of https://github.com/publiclab/plots2/pull/6254 and #6253. Thank you!