Standardize presentation of results on tag pages (Contributors)

TildaDares commented 3 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update the file config/locales/en.yml in the plots2 repository (press the little pen Icon) and edit the line as shown below.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -498,7 +498,7 @@ en:
       unfollow: "Click to unfollow"
       follow: "Follow"
       people_watching_tag: "%{count} people are watching this tag"
-      no_contributors: "No contributors for that tag; try searching for '<b>%{tag}</b>'"
+      no_contributors: "Hi! There are no contributors for this tag <span>&#x1F937</span>, try searching for <a href='/search/%{tag}'>%{tag}</a>"
       wild_card_search_detected: "Wildcard tag search detected. Wildcard tag searches
         use the * asterisk in their URLs, and will not show contributor listings."
       contributor: "Contributor"

[ ] 📝 Update the file app/views/tag/_contributors.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

 @@ -32,7 +32,7 @@
 <% if @wildcard %>
   <p><%= raw translation('tag.contributors.wild_card_search_detected', :tag => params[:id]) %></p>
 <% elsif @note_count.nil? || @note_count == 0 %>
-  <p><%= raw translation('tag.contributors.no_contributors', :tag => params[:id]) %>:</p>
+  <p><%= raw translation('tag.contributors.no_contributors', :tag => params[:id]) %></p>
 <% else %>
   <div class="row">
     <div class="col-md-6">

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

P0NC1K commented 3 years ago

Did my first contribution to an open source. Now I'm feeling like a real text-changing developer :))

majorhaji commented 3 years ago

Thank you very much Tilda, this has been very informative for a beginner to open source who is honestly feeling a tad intimidated by it all. Appreciate it!

TildaDares commented 3 years ago

@P0NC1K As you should🎉

TildaDares commented 3 years ago

@majorhaji Thank you ❤️, this means a lot.

aws107 commented 3 years ago

Hi, I don't think this has been taken yet-- could I work on this? Not sure I could do it today, but soon!

TildaDares commented 3 years ago

@aws107 Someone's already working on it.

cesswairimu commented 3 years ago

Hi @aws107 feel free to request a first-timer-only issue here #9083 if you are still looking for one. Thanks

cesswairimu commented 3 years ago

Hi @majorhaji, are you working on this? thanks

majorhaji commented 3 years ago

@cesswairimu I’m not but I’m willing to help

cesswairimu commented 3 years ago

Thanks @majorhaji , hi @TildaDares please remind me who is working on this...Thanks

TildaDares commented 3 years ago

@cesswairimu @P0NC1K is working on it.

cesswairimu commented 3 years ago

Cool thanks

publiclab / plots2