Make a Dockerfile and add a .dockerignore

publiclab / plotsbot

A bot for Public Lab

GNU General Public License v3.0

17 stars 28 forks source link

Make a Dockerfile and add a .dockerignore #91

Closed ryzokuken closed 6 years ago

ryzokuken commented 6 years ago

@icarito @jywarren take a look at this.

coveralls commented 6 years ago

Coverage remained the same at 94.118% when pulling 95e47e8a87cfb6f2c0b769cd2c7cdbf019778131 on dockerfile into 5e74c894e00bcf2f8e0968109bbf6d6db741e306 on master.

jywarren commented 6 years ago

Cool -- what does this change about the Docker setup? How was yarn working before?

Just catching up after the Barnraising, thanks!!!

ryzokuken commented 6 years ago

@jywarren We didn't have a Dockerfile before, which didn't allow us to containerize the bot and utilize Jenkins. Awaiting @icarito's further instructions.

icarito commented 6 years ago

Please merge this so we can test from master? Or pick a branch for production (we use stable for plots). Thanks and sorry for the delay!

ryzokuken commented 6 years ago

No worries, Sebastian!

I'm fine with using an alternate branch for production code, but we might as well keep master for the same purpose (at least for the time being, when our master isn't exactly cluttered with new code every day).

ryzokuken commented 6 years ago

Merging this!