search

publiclab / simple-data-grapher

Turns CSVs into graphs in a few simple steps; embeds onto other websites!
https://publiclab.github.io/simple-data-grapher/
GNU General Public License v3.0
39 stars 52 forks source link

ADD: Footer UI tests #120

Closed VladimirMikulic closed 4 years ago

VladimirMikulic commented 4 years ago

UI tests: - headings - paragraphs - buttons

Screenshot_20191219_024902

Resolves #119

welcome[bot] commented 4 years ago

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. Dangerbot will test out your code and reply in a bit with some pointers and requests. You can create issues here for any installation help There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 It would be great if you can tell us your Twitter handle so we can thank you properly?

debck commented 4 years ago

Great Work @VladimirMikulic

debck commented 4 years ago

Currently, there are two errors in the heading tests due to UI updates. That will be handled here in issue #118.

welcome[bot] commented 4 years ago

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well! Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝 Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.