search

publiclab / simple-data-grapher

Turns CSVs into graphs in a few simple steps; embeds onto other websites!
https://publiclab.github.io/simple-data-grapher/
GNU General Public License v3.0
38 stars 52 forks source link

Fix tests for Travis CI to pass #121

Closed Uzay-G closed 4 years ago

Uzay-G commented 4 years ago

Fixes #118

I fixed the tests. In one case there was a space on the title that shoulndn't have been there, and in the other there was an inconsistency between the sub-headings which I fixed.

You can check out the most recent functional build on Travis here: https://travis-ci.org/Uzay-G/simple-data-grapher/builds/627079233 Thanks! What do you think @debck @publiclab/reviewers

Uzay-G commented 4 years ago

Oh no sorry that's something left over from when I was trying to find the error. I can change it back tonight if you'd like?

On Thu, Dec 19, 2019, 08:24 Debasish Sahoo notifications@github.com wrote:

@debck commented on this pull request.

In spec/js/ui_tests.js https://github.com/publiclab/simple-data-grapher/pull/121#discussion_r359717152 :

 });

it ("should test sub heading", async function(){

  • const headingValue = await page.$eval('.sub_heading', el => el.innerHTML);
  • assert.equal(headingValue,"Plot and Export Graphs with CSV data");
  • const headingValue = await page.$eval('.sub_title', el => el.innerHTML);

Was there any requirement for changing .sub_heading to .sub_title.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/pull/121?email_source=notifications&email_token=AMTREYL5NIYKDDZUXCTSVG3QZMOUDA5CNFSM4J45PXB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPXT5EI#pullrequestreview-334446225, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTREYPNHNDUCGB5J6KOJSDQZMOUDANCNFSM4J45PXBQ .

debck commented 4 years ago

Yes, you can change it. Also, run the build command and try running the tests once again before you push. 👍 Good work Thanks

Uzay-G commented 4 years ago

Alright @debck! I changed it back to sub_heading. You can check out the build for that commit here: https://travis-ci.org/Uzay-G/simple-data-grapher/builds/627191993