Open IshaGupta18 opened 5 years ago
Awesome, how about import options? Like, standard modules to import from CSV URL, string, maybe even Google Spreadsheets later?
On Mon, May 20, 2019 at 5:59 AM Isha Gupta notifications@github.com wrote:
Here's a checklist of what is left to do:
- Integration with plots2
Model and Controller are ready. We need to establish routes and save files against the user.
- Displaying per-user data
Once the integration with plots2 is complete, we can move to its page design and implementation.
- Create charts from previously uploaded files
After integration, just have to list out the files uploaded by the user and normal flow resumes
-
Publish as a research note (Post Integration)
Browsable Time Slider (Work in progress)
Add Graph feature from the same CSV (Work in progress)
Add multiple graphs from multiple CSVs (Work in progress)
Export Options (Discussion)
More UI Designing (Work in progress)
@namangupta01 https://github.com/namangupta01 @jywarren https://github.com/jywarren what do you think is left and can be added here? Please feel free to! Thanks!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/26?email_source=notifications&email_token=AAAF6J4ROKH556ZIVNXIGITPWJY65A5CNFSM4HOALQ52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUV2X2A, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J3ZNVG6E223GZPDT7DPWJY65ANCNFSM4HOALQ5Q .
Yes, we can work on that! While you're at it, could you please have a look at a couple of PRs and issues we have put up in this repo? Thanks a lot!
On Mon, May 20, 2019, 7:09 PM Jeffrey Warren notifications@github.com wrote:
Awesome, how about import options? Like, standard modules to import from CSV URL, string, maybe even Google Spreadsheets later?
On Mon, May 20, 2019 at 5:59 AM Isha Gupta notifications@github.com wrote:
Here's a checklist of what is left to do:
- Integration with plots2
Model and Controller are ready. We need to establish routes and save files against the user.
- Displaying per-user data
Once the integration with plots2 is complete, we can move to its page design and implementation.
- Create charts from previously uploaded files
After integration, just have to list out the files uploaded by the user and normal flow resumes
-
Publish as a research note (Post Integration)
Browsable Time Slider (Work in progress)
Add Graph feature from the same CSV (Work in progress)
Add multiple graphs from multiple CSVs (Work in progress)
Export Options (Discussion)
More UI Designing (Work in progress)
@namangupta01 https://github.com/namangupta01 @jywarren https://github.com/jywarren what do you think is left and can be added here? Please feel free to! Thanks!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/publiclab/simple-data-grapher/issues/26?email_source=notifications&email_token=AAAF6J4ROKH556ZIVNXIGITPWJY65A5CNFSM4HOALQ52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUV2X2A , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAAF6J3ZNVG6E223GZPDT7DPWJY65ANCNFSM4HOALQ5Q
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/26?email_source=notifications&email_token=AJXHQZYP4RI7GXJ23ZQYZSTPWKS2HA5CNFSM4HOALQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVY3OMI#issuecomment-493991729, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ766USAMNGRL5KO63LPWKS2HANCNFSM4HOALQ5Q .
@jywarren we have importing feature from CSV URL (basically from a remote file). We can work for a big text area box for a string, and look up google spreadsheets too.
@jywarren as for importing data from a Google Sheet, we will need the user to sign in with the google, in order to access the user's data, so we will need a little planning around this.
If the user wants to upload a google sheet, they will simply have to sign in with a google account, and then we can access the sheet's data.
What do you think about this?
Actually i believe someone in LEL figured out how to do this without a signin - as long as the sheet is public! Take a look here -- and leave a comment for more info?
https://github.com/publiclab/leaflet-environmental-layers/pull/97
Awesome!
On Wed, May 29, 2019 at 9:40 AM Isha Gupta notifications@github.com wrote:
@jywarren https://github.com/jywarren as for importing data from a Google Sheet, we will need the user to sign in with the google, in order to access the user's data, so we will need a little planning around this.
If the user wants to upload a google sheet, they will simply have to sign in with a google account, and then we can access the sheet's data.
What do you think about this?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/26?email_source=notifications&email_token=AAAF6J2FLYC7GW5AFKS67G3PX2BRPA5CNFSM4HOALQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPLOJI#issuecomment-496940837, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J5B26QVUZKS36ZH4IDPX2BRPANCNFSM4HOALQ5Q .
So I tried and figured it out, and I found out, that for this to work, the sheet will have to be published on the web, something like what has been done at LEL: Like here
Then we can fetch data without logging in.
The question here is, is it worth the user, to publish data that might be sensitive to them on the web v/s asking the user to login to grant access. The latter one involves more work, however, that might be a safer option to the user. But since the user is allowing us to access the file's data, they may not mind publishing on the web, though that will involve them doing some additional work before coming and using the library. It is basically a tradeoff. What do you think @jywarren ?
@IgorWilbert @geekychasser what do you think about this?
I think perhaps we should offer some good guidance (with screenshots) on how to make it public, but simultaneously warn people what that will mean with regard to privacy. If they don't want to do it, they could just upload instead of using the Google Spreadsheets process.
Yes, I think that would be apt. We can write the steps required to upload a Google Sheet and it's repercussions. I have implemented this feature #32 !
On Thu, Jun 6, 2019, 2:34 AM Jeffrey Warren notifications@github.com wrote:
I think perhaps we should offer some good guidance (with screenshots) on how to make it public, but simultaneously warn people what that will mean with regard to privacy. If they don't want to do it, they could just upload instead of using the Google Spreadsheets process.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/26?email_source=notifications&email_token=AJXHQZ5KI5XMIB7CK4JE57DPZAS7NA5CNFSM4HOALQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBAOMI#issuecomment-499255089, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ6AGDWABSMITAYB4RDPZAS7NANCNFSM4HOALQ5Q .
Here's a checklist of what is left to do:
Model and Controller are ready. We need to establish routes and save files against the user.
Once the integration with plots2 is complete, we can move to its page design and implementation.
After integration, just have to list out the files uploaded by the user and normal flow resumes
[ ] Publish as a research note (Post Integration)
[x] Browsable Time Slider (Work in progress) [Implemented through Plotly]
[x] Add Graph feature from the same CSV (Work in progress)
[x] Add multiple graphs from multiple CSVs (Work in progress)
[ ] Export Options (Discussion) Save as Image (done) Save as Excel spreadsheet (done)
[ ] More UI Designing (Work in progress) A decent design is ready, which is easy to understand and work with. We will be advancing towards the complete design a little later in the timeline, so that the functional stuff can be implemented and tested on priority.
[ ] Testing (WIP) Learning about testing and testing frameworks. Also, some code will be restructured and refactored, as the process of going through testing made me realize that the code can be structured for a better understanding of it, as that's one of the reasons why tests are written: To easily understand what the code aims to achieve.
@namangupta01 @jywarren what do you think is left and can be added here? Please feel free to! Thanks!