publiclab / simple-data-grapher

Turns CSVs into graphs in a few simple steps; embeds onto other websites!

https://publiclab.github.io/simple-data-grapher/

GNU General Public License v3.0

39 stars 52 forks source link

[WIP] UI Design Stage2 #42

Closed IshaGupta18 closed 5 years ago

IshaGupta18 commented 5 years ago

Okay so this is the correct way of doing the job @namangupta01 thank you for correcting me! @jywarren kindly have a look at this one! I have tried to develop a workaround for fetching CSV data from a remote file, without getting the CORS (#35). It works well, however I am not able to pass the fetched data to another function, but I am able to print it at the console.

Also, I am facing the same bug I was facing here #39

@namangupta01 @IgorWilbert @gauravano @Souravirus I would really appreciate if you could help me debug here so that this PR is merged ASAP. Thanks a lot!

jywarren commented 5 years ago

Huh, interesting! Can you elaborate - you said you can't pass it, but when you try what happens? Thanks!

jywarren commented 5 years ago

Could a unit test be written against this intended functionality, to show the error?

IshaGupta18 commented 5 years ago

45 is the issue for this, I have pointed out the code there which is doing this. Its unable to access the data if I pass it to the other function, basically it enters the catch block. Let's discuss this one at #45. Thanks a lot!

jywarren commented 5 years ago

Hi, @IshaGupta18 -- thanks! Would you mind trying to push this to your github pages branch, along with your dependencies, so we can try it out? You'll need to make a gh-pages branch, and to add your node_modules folder within that branch, and push the whole thing up. Maybe @rexagod could help you with this as @rexagod recently did this in https://github.com/publiclab/matcher-core/issues/1

jywarren commented 5 years ago

Oh i missed your last comment. Checking now at #45

IshaGupta18 commented 5 years ago

Yes this is resolved, I have mentioned in #43 and this PR can be closed now. All the worked is shifted to #43 and let's have the discussion there. I am terribly sorry for creating confusion. @jywarren kindly review #43 ! Thanks a lot!