search

publiclab / simple-data-grapher

Turns CSVs into graphs in a few simple steps; embeds onto other websites!
https://publiclab.github.io/simple-data-grapher/
GNU General Public License v3.0
38 stars 52 forks source link

[DO NOT MERGE] Testing issues #48

Closed IshaGupta18 closed 5 years ago

IshaGupta18 commented 5 years ago

@rexagod here you go! KIndly let me know what might be the problem here

rexagod commented 5 years ago

This was resolved, closing now.

/cc @IshaGupta18 @namangupta01 @jywarren 

npm run test

> publiclab-grapher@0.0.1 test /mnt/c/Users/Rexagod/Desktop/simple-data-grapher
> ./node_modules/mocha/bin/mocha --require @babel/register --require @babel/polyfill --require jsdom-global/register spec/js/

  Sample Test
[Function: sampleTest]
    ✓ Should return Mocha Testing

  1 passing (45ms)
IshaGupta18 commented 5 years ago

@rexagod thanks a ton for your help here. Should I pull in these changes or copy them locally? Also, it would be great if you could tell me what exactly was going wrong here, which you fixed?

rexagod commented 5 years ago

@rexagod thanks a ton for your help here. Should I pull in these changes or copy them locally? Also, it would be great if you could tell me what exactly was going wrong here, which you fixed?

This was clarified in the chatroom. Also, @IshaGupta18, any reason for reopening this, since I thought we were done here?

IshaGupta18 commented 5 years ago

I just reopened it to check something out, I am closing it right away. Thanks again for your help!

On Mon, Jun 17, 2019, 9:20 PM Pranshu Srivastava notifications@github.com wrote:

@rexagod https://github.com/rexagod thanks a ton for your help here. Should I pull in these changes or copy them locally? Also, it would be great if you could tell me what exactly was going wrong here, which you fixed?

This was clarified in the chatroom. Also, @IshaGupta18 https://github.com/IshaGupta18, any reason for reopening this, since I thought we were done here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/pull/48?email_source=notifications&email_token=AJXHQZZL6XGOOX2NOYDJWADP26XF5A5CNFSM4HYUUN32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3TGUY#issuecomment-502739795, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ2ZFKY3CODTMQLY5RLP26XF5ANCNFSM4HYUUN3Q .

IshaGupta18 commented 5 years ago

Definitely, thanks again!

On Mon, Jun 17, 2019, 9:41 PM Pranshu Srivastava notifications@github.com wrote:

@rexagod commented on this pull request.

Sure. Let me know if anything else comes up! 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/pull/48?email_source=notifications&email_token=AJXHQZZXASVRW4KEQODNVATP26ZRZA5CNFSM4HYUUN32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3X45PA#pullrequestreview-250597052, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ65TBSVXJ66WMFL4ULP26ZRZANCNFSM4HYUUN3Q .