search

publiclab / simple-data-grapher

Turns CSVs into graphs in a few simple steps; embeds onto other websites!
https://publiclab.github.io/simple-data-grapher/
GNU General Public License v3.0
39 stars 52 forks source link

Remove console.log statements #51

Closed IshaGupta18 closed 5 years ago

IshaGupta18 commented 5 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

Excess console.log statements in src files.

📋Solution

Remove the console.log statements in the files below!

https://github.com/publiclab/simple-data-grapher/blob/bd7675221740380532f6663543e98ef337366b34/src/View.js#L36

https://github.com/publiclab/simple-data-grapher/blob/bd7675221740380532f6663543e98ef337366b34/src/View.js#L253

https://github.com/publiclab/simple-data-grapher/blob/bd7675221740380532f6663543e98ef337366b34/src/View.js#L256

https://github.com/publiclab/simple-data-grapher/blob/bd7675221740380532f6663543e98ef337366b34/src/View.js#L270

https://github.com/publiclab/simple-data-grapher/blob/bd7675221740380532f6663543e98ef337366b34/src/View.js#L319

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

mjkaehr commented 5 years ago

First time contributor! Can I claim this?

IshaGupta18 commented 5 years ago

Please go right ahead. When you clone the repo, do npm install to install the dependencies, and do npm run build, to see the changes in the main file. We'll be updating the README.md soon. Thanks a lot!

On Thu, Jun 20, 2019, 6:58 PM Morgan Kaehr notifications@github.com wrote:

First time contributor! Can I claim this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/51?email_source=notifications&email_token=AJXHQZZRD254D2MGY4HO3TLP3OAXXA5CNFSM4HZPL4CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFNFEQ#issuecomment-504025746, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ5MXC7U4PN5HJS5WZDP3OAXXANCNFSM4HZPL4CA .