Change 'Create Spreadsheet' button's style

IshaGupta18 commented 5 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

Change Create Spreadsheet button's bootstrap class and add a fa icon to it.

📋Solution

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update

In the following line: https://github.com/publiclab/simple-data-grapher/blob/ecaf7eddc52cafb49310b069ef0bc056a2dabbb2/src/View.js#L519

Change this:

<button type="button" class="btn btn-primary" id=' + this.createSpreadsheetButtonId + '> Create Spreadsheet</button>

TO

<button type="button" class="btn btn-success" id=' + this.createSpreadsheetButtonId + '> Create Spreadsheet <i class="fa fa-plus" aria-hidden="true"></i></button>

(This is being done to change the styling of the button)

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

SergeyTkachenko-Cj commented 5 years ago

claim)

IshaGupta18 commented 5 years ago

Go right ahead. When you clone the repo, do npm install to install the dependencies, and do npm run build, to see the changes in the main file. We'll be updating the README.md soon. Thanks a lot!

On Thu, Jun 20, 2019, 5:03 PM CJTaylor notifications@github.com wrote:

claim)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/53?email_source=notifications&email_token=AJXHQZ35C4GAX46WKVYPXVTP3NTHLA5CNFSM4HZPRBGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFEQQY#issuecomment-503990339, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZY2UXR7IGRGILHLQKTP3NTHLANCNFSM4HZPRBGA .

jayanth-karri22 commented 5 years ago

Is this issue still open? first timer as well :)

IshaGupta18 commented 5 years ago

Hey! This one's resolved now, we would be creating more FTOs and would love for you to help us out there. Thank you!

publiclab / simple-data-grapher