search

publiclab / simple-data-grapher

Turns CSVs into graphs in a few simple steps; embeds onto other websites!
https://publiclab.github.io/simple-data-grapher/
GNU General Public License v3.0
39 stars 52 forks source link

(linting): formatted the code to remove ESlint errors: #56

Closed osbornetunde closed 1 year ago

osbornetunde commented 5 years ago

Fixes #50 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

@rexagod I'm currentingly having issues linting the transpiled "PublicLab.Grapher.js" in dist directory.

We're happy to help you get this ready -- don't be afraid to ask for help!

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

IshaGupta18 commented 5 years ago

This is a pretty big PR here! Amazing work! However, it would be best if @rexagod would approve this one. We should wait for his comment here. Thanks a ton!

osbornetunde commented 5 years ago

That's cool. You are welcome

namangupta01 commented 5 years ago

Hi @osbornetunde, wow big pr. Nice work. There are conflicts in some files can you please fix them. And what do you think @jywarren , @rexagod and @IshaGupta18 should be not included dist/ in pr and only admin build and push to dist/ what do you guys think?

osbornetunde commented 5 years ago

@namangupta01 I have resolved the conflicts

rexagod commented 5 years ago

@namangupta01 I'm okay with the contributors (non-admins) pushing dist files into their PR branches.

Also, @IshaGupta18 @namangupta01 Let's get this one merged, so please let @osbornetunde know about the updation in the changes, if any, so we can accelerate things here if the code looks good to you. Thanks!

IshaGupta18 commented 5 years ago

This does look good to me! Great work here. I think from here on, we can ignore the dist files!

On Fri, Jun 28, 2019, 9:38 PM Pranshu Srivastava notifications@github.com wrote:

@namangupta01 https://github.com/namangupta01 I'm okay with the contributors (non-admins) pushing dist files into their PR branches.

Also, @IshaGupta18 https://github.com/IshaGupta18 @namangupta01 https://github.com/namangupta01 Let's get this one merged, so please let @osbornetunde https://github.com/osbornetunde know about the updation in the changes, if any, so we can accelerate things here if the code looks good to you. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/pull/56?email_source=notifications&email_token=AJXHQZ5UGRXUTLP4ZVTL533P4YZO3A5CNFSM4H2QFYI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2P2XQ#issuecomment-506789214, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZZTS2XQGKMF7BOOWITP4YZO3ANCNFSM4H2QFYIQ .

IgorWilbert commented 5 years ago

Nice work @osbornetunde, thanks a lot!!!

osbornetunde commented 5 years ago

@IgorWilbert you are welcome

dsuarezlogans commented 5 years ago

Hello is this PR going to be merge? Because I work in a fix that I would like to PR