search

publiclab / simple-data-grapher

Turns CSVs into graphs in a few simple steps; embeds onto other websites!
https://publiclab.github.io/simple-data-grapher/
GNU General Public License v3.0
39 stars 52 forks source link

Implementing CODAP export #66

Closed IshaGupta18 closed 5 years ago

IshaGupta18 commented 5 years ago

@jywarren @namangupta01 as you know I have been in conversation with @jsondoe from CODAP who has been helping me out a lot, so I began implementing the feature, after a lot of exploration and discussion on the plugin API. I am facing just a few issues in importing one of the files iframe-phone.js, apart from which, I was able to test the functioning in an example tester.

Here's how to works in the example and this is kind of what we will be implementing.

codap

And this is what is ready till now!

codapsdg

I have mailed @jsondoe about the issue and once we fix it, the feature will be ready! I once again thank him for all this help!

IgorWilbert commented 5 years ago

Awesome job @IshaGupta18 ! I left some comments, I hope they are helpful. Thank you!

IshaGupta18 commented 5 years ago

Okay so I have resolved the problems, and this is the latest PR, which covers other things as well.

IshaGupta18 commented 5 years ago

Here's the functioning of CODAP, which is working now! codapf

@jywarren @namangupta01 @IgorWilbert @gauravano @sagarpreet-chadha let me know if it's good to go!

Thanks a lot @jsandoe for your constant support and help!

jywarren commented 5 years ago

Wow this is really exciting. Is there a gh-pages demo I can try out? But go ahead and merge, this is tremendous!

IshaGupta18 commented 5 years ago

Oh thanks a lot! I will do it!

On Thu, Jul 25, 2019 at 9:55 PM Jeffrey Warren notifications@github.com wrote:

Wow this is really exciting. Is there a gh-pages demo I can try out? But go ahead and merge, this is tremendous!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/pull/66?email_source=notifications&email_token=AJXHQZZPYABSLUBGPR62STTQBHHXPA5CNFSM4IE6SGE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Z7ZKY#issuecomment-515112107, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ3WMGYTRRZ6FVH6WLDQBHHXPANCNFSM4IE6SGEQ .