Removing unused code - Githubissues

IshaGupta18 commented 5 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

Some of the code which was previously written is not required anymore.

📋Solution

Remove <button type="button" class="btn btn-success" id=' + this.gsheetId + '> Export as Google </button><div class="g-signin2" data-onsuccess=' + this.onSignIn + '></div> at line https://github.com/publiclab/simple-data-grapher/blob/fa222a480c402d15d260f70cb42c23694577e603/src/View.js#L347

and

https://github.com/publiclab/simple-data-grapher/blob/fa222a480c402d15d260f70cb42c23694577e603/src/View.js#L113-L115

in https://github.com/publiclab/simple-data-grapher/blob/main/src/View.js

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update
[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

noah56 commented 5 years ago

Hi! I'm new to GitHub but would like to start contributing to some open source projects. I have removed the lines from Vew.js. Do I also need to remove the "<button type="button" class=..." from some other file?

IshaGupta18 commented 5 years ago

No this one only, can you create a PR for this? Thanks a lot!

On Wed, Jul 24, 2019, 9:08 PM Noah notifications@github.com wrote:

Hi! I'm new to GitHub but would like to start contributing to some open source projects. I have removed the lines from Vew.js. Do I also need to remove the "<button type="button" class=..." from some other file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/68?email_source=notifications&email_token=AJXHQZ6MZ45XCDQYSKMW2FTQBBZQFA5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WXSPQ#issuecomment-514685246, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZZNWOFLIZF3QGGR4BLQBBZQFANCNFSM4IFYHIZQ .

gaddeharsha13 commented 5 years ago

Hi is this still open? Can I claim this issue?

IshaGupta18 commented 5 years ago

Yes, please go ahead!

sianlouisa commented 5 years ago

Hi, I'd like to work on this if it isn't currently in progress? Thanks!

IshaGupta18 commented 5 years ago

Yes go ahead!

On Tue, Oct 1, 2019, 2:23 PM Sian Lynch notifications@github.com wrote:

Hi, I'd like to work on this if it isn't currently in progress? Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/68?email_source=notifications&email_token=AJXHQZZD2FWRQBUMNB6C36TQMMF2HA5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAAQOOY#issuecomment-536938299, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ234FNO7FLMD5GGWQTQMMF2HANCNFSM4IFYHIZQ .

dsuarezlogans commented 5 years ago

Hello! is still available to work on? I'm first timer and I'll like to start with this Issue

IshaGupta18 commented 5 years ago

I think someone is working on it already?

On Wed, Oct 2, 2019, 3:02 AM Danny Suarez notifications@github.com wrote:

Hello! is still available to work on? I'm first timer and I'll like to start with this Issue

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/68?email_source=notifications&email_token=AJXHQZ5CFPZQCVGS4YZ542DQMO6YVA5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAC2EFA#issuecomment-537240084, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ55ADLMXG7WAACWOLLQMO6YVANCNFSM4IFYHIZQ .

futuregit commented 5 years ago

@IshaGupta18 Hello. First-timer. I see someone is working on it already. I would like to contribute, but I'm not sure where to start?

skathuria29 commented 5 years ago

Hi! Is this issue still up for grabs ?

IshaGupta18 commented 5 years ago

If there is no PR for it, go for it!

On Thu, Oct 24, 2019, 4:04 PM Saloni Kathuria notifications@github.com wrote:

Hi! Is this issue still up for grabs ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/68?email_source=notifications&email_token=AJXHQZ753LBYAUIR5GNY453QQF225A5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECERZ7Q#issuecomment-545856766, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXHQZY64PPCMP6QE6HDEJTQQF225ANCNFSM4IFYHIZQ .

anuk79 commented 5 years ago

@IshaGupta18 Hi, if no one is working on this, can I pick this up?

IshaGupta18 commented 5 years ago

If there is no PR, go for it!

On Sun, Oct 27, 2019, 12:27 PM Anuradha notifications@github.com wrote:

@IshaGupta18 https://github.com/IshaGupta18 Hi, if no one is working on this, can I pick this up?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/68?email_source=notifications&email_token=AJXHQZYKCF7PZNSQKMOGXOLQQU3UXA5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKXWIY#issuecomment-546667299, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXHQZZ7E7NL4KUWTSEUOB3QQU3UXANCNFSM4IFYHIZQ .

anuk79 commented 5 years ago

One pr has already been merged, so this issue can be closed I guess.

jywarren commented 5 years ago

Thank you!

publiclab / simple-data-grapher

Removing unused code #68

🤔 What you will need to know.

Problem

📋Solution

🤔❓ Questions?

Is someone else already working on this?