search

publiclab / simple-data-grapher

Turns CSVs into graphs in a few simple steps; embeds onto other websites!
https://publiclab.github.io/simple-data-grapher/
GNU General Public License v3.0
39 stars 52 forks source link

Redesign Add Graph Button #71

Closed VarsPhilos closed 5 years ago

VarsPhilos commented 5 years ago

Fixes #69 Added fa-chart-bar icon and changed style to match other buttons.

Did I do this pull request anywhere near correct?

IshaGupta18 commented 5 years ago

I am so sorry to have missed it, could you please provide a screenshot of the new design?

VarsPhilos commented 5 years ago

Thank you for the opportunity!

IMG_3554

IshaGupta18 commented 5 years ago

This looks good! Could you change the color of this button though?

VarsPhilos commented 5 years ago

It was blue originally, do you want it reverted back to that or do you have another color in mind?

IshaGupta18 commented 5 years ago

Some other color? Maybe you could try out a couple?

On Sat, Jul 27, 2019, 5:58 PM Vars notifications@github.com wrote:

It was blue originally, do you want it reverted back to that or do you have another color in mind?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/pull/71?email_source=notifications&email_token=AJXHQZ33MQJPGF6ABR4KQFTQBQ5QDA5CNFSM4IF5STO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26KR5Q#issuecomment-515680502, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZY4UU7DPTSRFYNWL6LQBQ5QDANCNFSM4IF5STOQ .

IMRC21 commented 5 years ago

In my opinion, a gradient would look really nice. Btn_1 background-image: linear-gradient( 359.8deg, rgba(56,104,178,1) 7.3%, rgba(31,67,122,1) 84.8% );

Btn_2 background-image: linear-gradient( 90.6deg, rgba(26,109,85,1) -0.1%, rgba(49,227,125,1) 105.9% );

Btn_3 background-image: linear-gradient( 90.6deg, rgba(77,34,109,1) -1%, rgba(90,142,253,1) 153.1% );

IshaGupta18 commented 5 years ago

This looks good! Maybe you can try out the first one, along with the fa-icon given by @VarsPhilos ? Thanks a lot!