publiclab / spectral-workbench

Web-based tools for collecting, analyzing, and sharing data from a DIY spectrometer
http://spectralworkbench.org
GNU General Public License v3.0
129 stars 159 forks source link

Lost in calibration... #354

Open viechdokter opened 8 years ago

viechdokter commented 8 years ago

I was just looking at an extremely flickering waterfall picture of a (already calibrated) CFL spectrum. I was wondering if the flickering only affected intensities or wavelengths, too. So I used the "SET NEW CROSS SECTION" button to use a different line number of the picture. As soon as I hit "APPLY" the spectrum lost its calibration and went back to "uncalibrated pixels".

Warren proposed to add some code to the program to ask "does the calibration still hold?" so that you don't have to recalibrate each time you choose a new cross section.

I am not a good programmer so I ask you guys out there: any ideas how to put that into the next spectral workbench update?

jywarren commented 8 years ago

Thanks! very helpful. I think we could have an extra checkbox that's not checked by default, that asks:

[ ] Re-apply prior calibration (only check this if you are sure the

calibration won't have shifted; typically only if you used live capture, and not likely if you uploaded an image)

This'd actually be done in the SpectralWorkbench.js code, here: https://github.com/publiclab/spectral-workbench.js/blob/master/src/ui/SpectralWorkbench.UI.ToolPaneTypes.js#L223

I believe we'd query the checkbox like this: $(this).prop('checked') and if it is checked, we'd add a line after this:

https://github.com/publiclab/spectral-workbench.js/blob/master/src/ui/SpectralWorkbench.UI.ToolPaneTypes.js#L247

with something like form.graph.datum.addAndUploadTag('calibrate:xxx') which we could pull from existing tags, probably using form.graph.datum.getTag('calibrate')...

On Wed, Apr 13, 2016 at 3:26 PM, viechdokter notifications@github.com wrote:

I was just looking at an extremely flickering waterfall picture of a (already calibrated) CFL spectrum. I was wondering if the flickering only affected intensities or wavelengths, too. So I used the "SET NEW CROSS SECTION" button to use a different line number of the picture. As soon as I hit "APPLY" the spectrum lost its calibration and went back to "uncalibrated pixels".

Warren proposed to add some code to the program to ask "does the calibration still hold?" so that you don't have to recalibrate each time you choose a new cross section.

I am not a good programmer so I ask you guys out there: any ideas how to put that into the next spectral workbench update?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/publiclab/spectral-workbench/issues/354