search

publiclab / webjack

a JavaScript library that uses an audio software modem to communicate with an Arduino via a headphone jack
https://webjack.io
GNU General Public License v3.0
135 stars 26 forks source link

Safari compatibility #91

Closed daz closed 5 years ago

daz commented 5 years ago

Send and receive tested on desktop and iOS Safari

welcome[bot] commented 5 years ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

welcome[bot] commented 5 years ago

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://webjack.io/examples in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly? Now that you've completed this, you can help someone else take their first step! See: Public Lab's coding community!

jywarren commented 5 years ago

Super!!!! tested in Chrome to be sure it's backwards-compatible. We're good now!

jywarren commented 5 years ago

Ah, I need to build this. Re-releasing as 0.1.6 in a moment!

jywarren commented 5 years ago

Thanks SO MUCH!

Do you have any experience with iOS video? We've been dying to try to get this lib working there too, although the changes are a bit more involved: https://github.com/publiclab/spectral-workbench.js/issues/87

Thanks!!!

jywarren commented 5 years ago

Done!

jywarren commented 5 years ago

Hmm I also just tested this on an iPhone and was unable to get it to work. I'm wondering if the demo (with your new code) works for you in Safari on iOS?

Another possibility is the change in API from navigator.getusermedia to navigator.mediadevices.getusermedia (I think) --

https://github.com/eduardolundgren/tracking.js/issues/228