search

publiclab / webjack

a JavaScript library that uses an audio software modem to communicate with an Arduino via a headphone jack
https://webjack.io
GNU General Public License v3.0
136 stars 26 forks source link

Equalizer/fft graph not shown on Android phones #93

Open jywarren opened 5 years ago

jywarren commented 5 years ago

https://github.com/publiclab/webjack/issues/88, #87 and #92 fixed the audio security limits issue and installed an equalizer to display what sounds it can hear on the spectrum, for debugging. It's awesome!

image

However, on my Android phone in Chrome 73, I can't see the graph:

Screenshot_20190416-144130

I can't reproduce this on desktop Chrome:

image

Not sure what's happening here!

jywarren commented 5 years ago

Here's the section that's supposed to draw the graph!

https://github.com/publiclab/webjack/blob/04c0def1f5f489c65558154f548f707bdca85816/examples/fft/sketch.js#L40-L46

selevo commented 3 years ago

test soul brauser on android. Chrome browser hasn't been very good lately

jywarren commented 3 years ago

aww darn, any way you could test with a javascript console? Thanks for reporting!

On Mon, Jul 19, 2021 at 3:39 AM Serega @.***> wrote:

test soul brauser on android. Chrome browser hasn't been very good lately

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/webjack/issues/93#issuecomment-882318312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J4H77FVW53BB4UYSULTYPJENANCNFSM4HGN2Z7A .

selevo commented 3 years ago

aww darn, any way you could test with a javascript console? Thanks for reporting!

https://editor.p5js.org/jywarren/sketches/rkztwSt8M (android brouser)

#ReferenceError: webkitAudioContext is not defined
    at Class.init (https://webjack.io/dist/webjack.js:663:44)

    at new Class (https://webjack.io/dist/webjack.js:63:19)

    at (anonymous function) (https://jywarren.github.io/p5-webjack/lib.js:15:20)

    at (anonymous function) (https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.8.0/addons/p5.sound.min.js:24:4838)(https://github.com/publiclab/webjack/issues/93#issuecomment-882318312)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J4H77FVW53BB4UYSULTYPJENANCNFSM4HGN2Z7A> .

webkitAudioContext - is out of date

https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Migrating_from_webkitAudioContext

jywarren commented 3 years ago

Ah. Hm. I wonder if this is fixed in a more recent version of p5.js; we seem to be at v0.8.0. I searched for the error in their repo but found nothing but their current version is v1.4.0: https://github.com/processing/p5.js/

We could try bumping our version...

On Sat, Aug 14, 2021 at 8:30 AM Serega @.***> wrote:

aww darn, any way you could test with a javascript console? Thanks for reporting! … <#m8691155359467393051> On Mon, Jul 19, 2021 at 3:39 AM Serega @.***> wrote: test soul brauser on android. Chrome browser hasn't been very good lately — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <[#93 https://github.com/publiclab/webjack/issues/93 (comment)]

https://editor.p5js.org/jywarren/sketches/rkztwSt8M

ReferenceError: webkitAudioContext is not defined

at Class.init (https://webjack.io/dist/webjack.js:663:44)

at new Class (https://webjack.io/dist/webjack.js:63:19)

at (anonymous function) (https://jywarren.github.io/p5-webjack/lib.js:15:20)

at (anonymous function) (https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.8.0/addons/p5.sound.min.js:24:4838)(https://github.com/publiclab/webjack/issues/93#issuecomment-882318312)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J4H77FVW53BB4UYSULTYPJENANCNFSM4HGN2Z7A .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/webjack/issues/93#issuecomment-898888460, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J2WTVEZEBNLTEL27FDT4ZOXZANCNFSM4HGN2Z7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

jywarren commented 3 years ago

Wow, we're actually at v0.7.3 of p5js:

https://github.com/publiclab/webjack/blob/5995944d8e353e01a555976ebeeb0e5a6a6b8460/examples/index.html#L16-L18

Would you be able to try bumping the version in the CDN links and trying again? If not I can try.

Noting also that the code referenced in your error log mentions this wrapper library I also wrote, but there's no reference to "webkit" in the code there so I think that's not the issue. But still, good to notice the included code:

https://github.com/jywarren/p5-webjack/blob/main/lib.js

jywarren commented 3 years ago

thanks so much for helping out here!!!

selevo commented 3 years ago

i dont know how get js errors on android brausers whithout conect to PC In android brausers no console. at the moment I only have an Android smartphone

I can only validate code in some JavaScript sandbox, editor.p5js.org or others

selevo commented 3 years ago

thanks so much for helping out here!!! webjack.io-1629558757386.log

1

jywarren commented 3 years ago

oh whoa... cert invalid! This i think i can fix. I don't know if it'll fix things on Android but it's a good first step to get out of the way.

On Sun, Aug 22, 2021 at 11:26 AM Serega @.***> wrote:

thanks so much for helping out here!!! webjack.io-1629558757386.log https://github.com/publiclab/webjack/files/7027624/webjack.io-1629558757386.log

[image: 1] https://user-images.githubusercontent.com/13694921/130360748-dab06750-07d6-47ff-a7cb-de18fb042ca5.gif

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/webjack/issues/93#issuecomment-903285905, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J7LI5G7S75THCATSMLT6EJIZANCNFSM4HGN2Z7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

jywarren commented 3 years ago

That's odd... I see this:

Screen Shot 2021-08-22 at 12 54 30 PM

Let me see what's up.

jywarren commented 3 years ago

What version of Chrome are you using?

jywarren commented 3 years ago

I don't know if this is the problem on Android but it makes me wonder, what is your Android version and Android Chrome version too?

chrome://settings/help can help you determine this.

Would you be able to try out the other change as well, the update to p5js v1.4.0, to see if that helps?

https://github.com/publiclab/webjack/pull/202 I've tried the update here. Do you know how to start it up to test? You could use GitPod --

http://gitpod.io/#https://github.com/publiclab/webjack/pull/202

once it starts up, you'll see the example page in the preview window.

selevo commented 3 years ago

The interface there is very slow and it is intended for a computer, the page does not move well on the phone and the navigation is bad I can not check the scripts

selevo commented 2 years ago

https://github.com/publiclab/webjack/issues/208