publiclab / webjack

a JavaScript library that uses an audio software modem to communicate with an Arduino via a headphone jack
https://webjack.io
GNU General Public License v3.0
135 stars 26 forks source link

reference to window breaks tests #97

Closed jywarren closed 5 years ago

jywarren commented 5 years ago

This fixed iOS compatibility in #43 but breaks the tests, which is silly! Many thanks for the iOS fix; this should be easy to resolve:

https://github.com/publiclab/webjack/blob/3498536454f63c8ae950dd910bc46606c50dcdf4/src/webjack.js#L15

Failing test: https://travis-ci.org/publiclab/webjack/jobs/521502504

https://github.com/publiclab/webjack/pull/91/files#r276480540 has some suggestions, including just removing window. from both references.