search

publiclab / wherewebreathe

wherewebreathe.org
2 stars 7 forks source link

trigger automatic bower install with a postinstall hook #130

Closed ghost closed 9 years ago

ghost commented 9 years ago

This patch uses npm's postinstall lifecycle scripts feature to make the bower install step automatically run after npm install. This way developers working on this project only need to do npm install.

jywarren commented 9 years ago

Hi, James, can you rebase this? We had a small commit from someone else. Also, how do you want to coordinate pulls etc? Do you anticipate tackling the project in a number of distinct feature branches, with their own PRs? It being a young project, we don't really have any policies in place, so it's kind of your option. And we almost never get outside PRs -- this one was an exception.

Welcome to the project!

ghost commented 9 years ago

I think it's good to do separate pull requests so that other folks on the project and community have a chance to offer feedback and code review, even if I'm given contributor access.

In my own projects and many projects I help maintain we use this model: http://openopensource.org/ In open open source, people who submit substantial patches are automatically given commit rights but the expectation is that significant modifications happen through internal pull requests to keep everyone in the loop.

Anyhow, rebased and ready to merge!

jywarren commented 9 years ago

Super. I'll read that over, thanks!