publicsuffix / list

The Public Suffix List
https://publicsuffix.org/
Mozilla Public License 2.0
1.97k stars 1.2k forks source link

Add StackBlitz #1939

Closed d3lm closed 4 months ago

d3lm commented 5 months ago

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

Submitter affirms the following:


For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

Description of Organization

StackBlitz is an instant fullstack web IDE for the JavaScript ecosystem. It's powered by WebContainers, the first WebAssembly-based operating system which boots the Node.js environment in milliseconds, securely within your browser tab.

I am a Founding Engineer and Team Lead for WebContainer at StackBlitz.

Organization Website: https://stackblitz.com

Reason for PSL Inclusion

WebContainer is designed to be fully sandboxed and runs inside an iframe which gets embedded in our editor on https://stackblitz.com/, or sites like learn.svelte.dev, or angular.dev. For this iframe we use a set of 3 different domains including:

We're seeking inclusion of these three domains into the PSL for the following purposes:

Number of users this request is being made to serve: >1M/Month

DNS Verification via dig

dig +short TXT _psl.w-staticblitz.com
"https://github.com/publicsuffix/list/pull/1939"
dig +short TXT _psl.w-credentialless-staticblitz.com
"https://github.com/publicsuffix/list/pull/1939"
dig +short TXT _psl.w-corp-staticblitz.com
"https://github.com/publicsuffix/list/pull/1939"

Results of Syntax Checker (make test)

PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_fuzzer
PASS: libpsl_icu_load_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
PASS: test-is-public-builtin
PASS: test-is-public
PASS: test-is-public-all
PASS: test-is-cookie-domain-acceptable
PASS: test-registrable-domain
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
simon-friedberger commented 5 months ago

The DNS entries should be on an _psl. entry.

d3lm commented 5 months ago

@simon-friedberger Thanks for your review 🙏. Fixed the sorting of the domains and also set up the correct DNS records on the _psl. entry for all domains.

simon-friedberger commented 5 months ago

Stackhero, Staclar, Stackblitz?

simon-friedberger commented 5 months ago
d3lm commented 5 months ago

@simon-friedberger I think I got the sorting right this time.

d3lm commented 5 months ago

Also updated the reasoning to be simpler, less verbose, and hopefully clearer now.

d3lm commented 5 months ago

@dnsguru Hey 👋 Is there a timeline that we can expect this to be merged?