anthonyryan1 commented 5 months ago

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

[X] Description of Organization
[X] Robust Reason for PSL Inclusion
[X] DNS verification via dig
[X] Run Syntax Checker (make test)
[X] Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

[X] We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
[X] This request was not submitted with the objective of working around other third-party limits
[X] The Guidelines were carefully read and understood, and this request conforms
[X] The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

[X] Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Whatbox is an app hosting company operating since 2011. Our customers include both small businesses and prosumers.

We sell hosting solutions for resource-intensive open source applications. Software that requires multi-gigabit network speeds, terabytes of storage space and intensive CPU operations like video transcoding.

We help simplify the configuration, security and updates of these applications while collaborating with open source developers.

This request is Anthony Ryan, CEO of Whatbox Inc.

Organization Website: whatbox.ca

Reason for PSL Inclusion

We provide each customer with a subdomain under box.ca, the marketing being "what (is your) box", that is secured by LetsEncrypt SSL certificates.

LetsEncyrpt has been kind enough to raise our renewal rates when it has been necessary, so we have no current or anticipated problems there.

We wish to be added to the public suffix list to avoid the risk of cookie theft between subdomains. Because each subdomain belongs to a separate customer, having them within the same domain namespace is a security risk that the public suffix list can mitigate.

Number of users this request is being made to serve: Over 9000!

DNS Verification via dig

dig +short TXT _psl.box.ca
"https://github.com/publicsuffix/list/issues/1950"

Results of Syntax Checker (`make test`)

PASS: libpsl_icu_fuzzer
PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_load_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests

...

PASS: test-is-public-builtin
PASS: test-is-cookie-domain-acceptable
PASS: test-is-public
PASS: test-registrable-domain
PASS: test-is-public-all
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc

yahesh commented 4 months ago

@anthonyryan1 Your block does not follow the sorting order. Your company Whatbox Inc. should be located above WIARD Enterprises, but it is currently located above Western Digital Technologies, Inc. This needs to be fixed.

anthonyryan1 commented 4 months ago

@yahesh amended, apologies for the oversight.

Would you like me to contribute a test to validate sorting order in a separate pull request after this? Seems like something computers can enforce effectively.

simon-friedberger commented 4 months ago

@yahesh amended, apologies for the oversight.

Would you like me to contribute a test to validate sorting order in a separate pull request after this? Seems like something computers can enforce effectively.

There is even a work in progress you could contribute to: https://github.com/publicsuffix/list/pull/1953

anthonyryan1 commented 4 months ago

Sorry for the buggy commit in the middle, was testing #1953 against the problematic commit and found it's not yet detecting this problem.

simon-friedberger commented 4 months ago

Sorry for the buggy commit in the middle, was testing #1953 against the problematic commit and found it's not yet detecting this problem.

1953 is not active yet! It's an open PR!

simon-friedberger commented 3 months ago

[x] Expiration (Note: Must STAY >2y at all times)
- [x] box.ca expires 2034-02-01
[x] DNS _psl entries (Note: Must STAY in place)
[x] Tests pass
[x] Sorting
[x] Reasoning/Organization description

simon-friedberger commented 3 months ago

Your _psl record is missing a '/pull'

anthonyryan1 commented 3 months ago

Corrected

dig +short TXT _psl.box.ca
"https://github.com/publicsuffix/list/pull/1950"