publicsuffix / list

The Public Suffix List
https://publicsuffix.org/
Mozilla Public License 2.0
1.97k stars 1.2k forks source link

Add `wixstudio.com` #1971

Closed alonkochba closed 2 months ago

alonkochba commented 3 months ago

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

Submitter affirms the following:


For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

Description of Organization

Wix is a website building platform.

Registered developers can create apps and get their own subdomain (e.g. username.wixstudio.com) on which their sites are hosted.

Organization Website: https://www.wix.com/

Reason for PSL Inclusion

We'd like to properly isolate each subdomain to prevent global cookie setting on wixstudio.com and highlight that each subdomain hosts sites of a different user, unrelated to the others.

Number of users this request is being made to serve:

DNS Verification via dig

dig +short TXT _psl.wixstudio.com https://github.com/publicsuffix/list/pull/1971

Results of Syntax Checker (make test)

============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
alonkochba commented 3 months ago

@shahata

yahesh commented 3 months ago

@alonkochba Please order your block correctly. Entries are ordered by TLD first and then by the SLD (so-called right-to-left sorting). So wixstudio.com should follow after wixsite.com.

yahesh commented 3 months ago

Also, the whole block for Wix.com, Inc. is in the wrong spot. It should be located below WISP but is actually located below WP Engine.

yahesh commented 3 months ago

Sorting looks good to me now.

simon-friedberger commented 3 months ago
alonkochba commented 3 months ago

Thanks, I am only adding wixstudio.com here, the rest is refactoring, but I will reach out to make sure the others are extended as well and PSL is readded.

simon-friedberger commented 3 months ago

@alonkochba Any updates?

alonkochba commented 2 months ago

Hi, all comments done

  1. domains expiration updated
  2. _psl DNS entries added for all domains pointing to this PR
  3. changed mail to publicsuffixlist@wix.com
alonkochba commented 2 months ago

PR check seems to fail on someone else's entry, any idea why?

Checking TXT entry for _psl.emrnotebooks-prod.ap-south-2.amazonaws.com. DNS answer: "https://github.com/publicsuffix/list/pull/1919" -> PR 1919

simon-friedberger commented 2 months ago

PR check seems to fail on someone else's entry, any idea why?

Checking TXT entry for _psl.emrnotebooks-prod.ap-south-2.amazonaws.com. DNS answer: "#1919" -> PR 1919

I'm working on it, don't worry about it. It's not your fault. :)

simon-friedberger commented 2 months ago

Please tick the box saying that you will keep the 2 years validity.