publicsuffix / list

The Public Suffix List
https://publicsuffix.org/
Mozilla Public License 2.0
1.97k stars 1.2k forks source link

Add 6 new domains to Lukanet Ltd Private domains #1977

Closed lukavia closed 2 months ago

lukavia commented 3 months ago

Checklist

Submitter affirms the following:

Description of Organization

Organization Website: https://lukanet.com Product Website: https://barsy.bg

Lukanet Ltd is the owner and developer of a software for managing Bar, Restourants and other Businesses called Barsy. We already have a number of domains included in the list for the same reasons we want to include those new ones.

Reason for PSL Inclusion

For each installation our clients get a subdomain so they can access their system via web without having to incur additional fees for domains, static IP address or dyndns as this is handled by our system. Since each installation belongs to a separated legal entity and deals with that entity valuable financial information, security is top concern for us and our clients. It has proven that having the subdomains recognized by the browsers as separate domains and not share cookies or other vital information is a good working practise. We've number of included domains already in the list like: barsy.bg, barsy.uk, etc. We are adding new domains as we are expanding further and gaining new clients.

Previous PR request for our domains are:

Number of users this request is being made to serve: This is hard to tell since it strongly depends on the number of clients and how many users each client has. The current client list and their users is in the range of tens of thousands.

DNS Verification via dig

dig +short TXT _psl.barsy.dev
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.gr
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.rs
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsyonline.shop
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsyonline.menu
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.store
"https://github.com/publicsuffix/list/pull/1977"

Results of Syntax Checker (make test)

PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_fuzzer
PASS: libpsl_icu_load_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       test-is-public-all.o
  CC       common.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-public
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-all
  CCLD     test-is-public-builtin
  CCLD     test-registrable-domain
PASS: test-is-public-builtin
PASS: test-is-public
PASS: test-is-cookie-domain-acceptable
PASS: test-registrable-domain
PASS: test-is-public-all
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc
yahesh commented 3 months ago

Sorting looks good to me.

simon-friedberger commented 3 months ago
simon-friedberger commented 3 months ago

Please ensure that all domains have PSL entries and a remaining validity of >2 years. And not just the ones you are adding!

How many users are there per domain?

lukavia commented 2 months ago

All domains are extended beyond 2y except the once that do not allow it (.de, .eu)

$ for f in $(fgrep barsy public_suffix_list.dat); do echo -n "$f ";whois $f | grep -v 'Registered until' | egrep -i "(Expires|Expiry|^Expiration date:)" || echo ""; done
barsy.ca Registry Expiry Date: 2026-09-17T16:11:52Z
barsy.bg 
barsy.co.uk         Expiry date:  13-Dec-2026
barsyonline.co.uk         Expiry date:  13-Dec-2026
barsycenter.com    Registry Expiry Date: 2027-05-14T07:55:00Z
barsyonline.com    Registry Expiry Date: 2027-05-14T07:55:00Z
barsy.club Registry Expiry Date: 2027-02-19T23:59:59Z
barsy.de 
barsy.dev Registry Expiry Date: 2027-05-12T11:08:09Z
barsy.eu 
barsy.gr 
barsy.in Registry Expiry Date: 2026-10-20T15:19:21Z
barsy.info Registry Expiry Date: 2026-10-20T15:19:21Z
barsy.io Registry Expiry Date: 2027-02-20T18:28:58Z
barsy.me Registry Expiry Date: 2026-10-20T15:19:21Z
barsy.menu Registry Expiry Date: 2027-02-02T13:19:55Z
barsy.mobi Registry Expiry Date: 2026-10-20T15:27:30Z
barsy.net    Registry Expiry Date: 2026-10-27T09:39:58Z
barsy.online Registry Expiry Date: 2027-02-20T23:59:59.0Z
barsy.org Registry Expiry Date: 2026-10-27T09:39:58Z
barsy.pro Registry Expiry Date: 2026-10-20T15:19:21Z
barsy.pub Registry Expiry Date: 2027-02-02T13:19:55Z
barsy.ro   Expires On: 2026-08-23
barsy.rs Expiration date: 18.04.2027 20:49:13
barsy.shop Registry Expiry Date: 2026-12-13T23:59:59.0Z
barsy.site Registry Expiry Date: 2027-02-20T23:59:59.0Z
barsy.support Registry Expiry Date: 2026-10-20T15:39:23Z
barsy.uk         Expiry date:  13-Dec-2026

Since keeping _psl entries is a condition to stay in the list all previous domains have their original _psl entries:

$ for f in $(fgrep barsy public_suffix_list.dat); do echo dig +short TXT _psl.$f;dig +short TXT _psl.$f; done
dig +short TXT _psl.barsy.ca
"https://github.com/publicsuffix/list/pull/732"
dig +short TXT _psl.barsy.bg
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.co.uk
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsyonline.co.uk
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsycenter.com
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsyonline.com
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.club
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.de
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.dev
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.eu
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.gr
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.in
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.info
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.io
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.me
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.menu
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.mobi
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.net
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.online
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.org
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.pro
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.pub
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.ro
"https://github.com/publicsuffix/list/pull/1402"
dig +short TXT _psl.barsy.rs
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.shop
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.site
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.support
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.uk
"https://github.com/publicsuffix/list/pull/596"

I can update them if you want?

As per users the numbers would be in the hundred and in some cases thousands.

lukavia commented 2 months ago

Quick question. If I want to add 2 more domains is it too late to do it here, or should I file a new pull request later?

simon-friedberger commented 2 months ago

Original PSL entries are good, it helps find the PR sometimes. Yes, you can add more domains.

lukavia commented 2 months ago

Done. Hera are the results for the TXT _pls entries and the expiration for all our domains after the update:

$ for f in $(fgrep barsy public_suffix_list.dat); do echo dig +short TXT _psl.$f;dig +short TXT _psl.$f; done
dig +short TXT _psl.barsy.ca
"https://github.com/publicsuffix/list/pull/732"
dig +short TXT _psl.barsy.bg
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.club
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsycenter.com
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsyonline.com
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.de
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.dev
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.eu
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.gr
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.in
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.info
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.io
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.me
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.menu
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsyonline.menu
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.mobi
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.net
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.online
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.org
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.pro
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.pub
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.ro
"https://github.com/publicsuffix/list/pull/1402"
dig +short TXT _psl.barsy.rs
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.shop
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsyonline.shop
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.site
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.store
"https://github.com/publicsuffix/list/pull/1977"
dig +short TXT _psl.barsy.support
"https://github.com/publicsuffix/list/pull/439"
dig +short TXT _psl.barsy.uk
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsy.co.uk
"https://github.com/publicsuffix/list/pull/596"
dig +short TXT _psl.barsyonline.co.uk
"https://github.com/publicsuffix/list/pull/596"
$ for f in $(fgrep barsy public_suffix_list.dat); do echo -n "$f ";whois $f | grep -v 'Registered until' | egrep -i "(Expires|Expiry|^Expiration date:)" || echo ""; done
barsy.ca Registry Expiry Date: 2026-09-17T16:11:52Z
barsy.bg 
barsy.club Registry Expiry Date: 2027-02-19T23:59:59Z
barsycenter.com    Registry Expiry Date: 2027-05-14T07:55:00Z
barsyonline.com    Registry Expiry Date: 2027-05-14T07:55:00Z
barsy.de 
barsy.dev Registry Expiry Date: 2027-05-12T11:08:09Z
barsy.eu 
barsy.gr 
barsy.in Registry Expiry Date: 2026-10-20T15:19:21Z
barsy.info Registry Expiry Date: 2026-10-20T15:19:21Z
barsy.io Registry Expiry Date: 2027-02-20T18:28:58Z
barsy.me Registry Expiry Date: 2026-10-20T15:19:21Z
barsy.menu Registry Expiry Date: 2027-02-02T13:19:55Z
barsyonline.menu Registry Expiry Date: 2027-03-17T16:37:53Z
barsy.mobi Registry Expiry Date: 2026-10-20T15:27:30Z
barsy.net    Registry Expiry Date: 2026-10-27T09:39:58Z
barsy.online Registry Expiry Date: 2027-02-20T23:59:59.0Z
barsy.org Registry Expiry Date: 2026-10-27T09:39:58Z
barsy.pro Registry Expiry Date: 2026-10-20T15:19:21Z
barsy.pub Registry Expiry Date: 2027-02-02T13:19:55Z
barsy.ro   Expires On: 2026-08-23
barsy.rs Expiration date: 18.04.2027 20:49:13
barsy.shop Registry Expiry Date: 2026-12-13T23:59:59.0Z
barsyonline.shop Registry Expiry Date: 2026-08-02T23:59:59.0Z
barsy.site Registry Expiry Date: 2027-02-20T23:59:59.0Z
barsy.store Registry Expiry Date: 2027-03-19T23:59:59.0Z
barsy.support Registry Expiry Date: 2026-10-20T15:39:23Z
barsy.uk         Expiry date:  13-Dec-2026
barsy.co.uk         Expiry date:  13-Dec-2026
barsyonline.co.uk         Expiry date:  13-Dec-2026

P.S. The registrar for .eu and .de doesn't allow more than 2 year renewal.