publicsuffix / list

The Public Suffix List
https://publicsuffix.org/
Mozilla Public License 2.0
2.03k stars 1.22k forks source link

Add Strapi domains #1982

Closed Baldinof closed 3 months ago

Baldinof commented 4 months ago

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

Submitter affirms the following:


For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

Description of Organization

We are Strapi.io and we develop an open-source headless CMS. Our users create their own Strapi project to manage their content and data.

We also provide cloud hosting services for our users, so they can deploy their Strapi project on our platform.

I am Florent Baldino, I work as an SRE at Strapi.io specifically on the cloud hosting platform.

Organization Website:

https://strapi.io

Reason for PSL Inclusion

A Strapi project is a node.js application that needs to be hosted.

We created Strapi Cloud to let our customers deploy their Strapi project:

We would like strapiapp.com to be on the PSL in order to:

DNS Verification via dig

dig +short TXT _psl.strapiapp.com
"https://github.com/publicsuffix/list/pull/1982"
dig +short TXT _psl.media.strapiapp.com
"https://github.com/publicsuffix/list/pull/1982"

Results of Syntax Checker (make test)

Waiting for CI run

yahesh commented 4 months ago

Sorting looks good to me.

simon-friedberger commented 4 months ago

See:

  • [x] Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section
trabelsiemna8 commented 4 months ago
  • [ ] Expiration (Note: Must STAY >2y at all times)

    • [ ] strapiapp.com expires 2024-11-22
  • [x] DNS _psl entries (Note: Must STAY in place)
  • [x] Tests pass
  • [x] Sorting (TY @yahesh)
  • [x] Reasoning/Organization description

See:

  • [x] Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Hello, is it mandatory to extend domain registration, even though the auto-renewal is already set?

dnsguru commented 4 months ago

Short answer is Yep.

Most registries publish the expiration date in whois / rdap so that it can be looked up and not burn volunteer reviewer cycles.

Putting an entry in the PSL has a long term impact, so having an expiration date that is also long term helps signal from the requestor that they are committed to the domain(s) in the request.

Temporary entries are not acceptable. Domains can be renewed to an extended a period of up to 10 years. 10 seemed long. Many of us wanted 5, but we settled on 2.

Less time than that signals that the domain names might not renew and would leave debris for PSL maintainers and future registrant to deal with, which wastes a lot of time and causes problems for all involved except the one who requested the now-stale entry that breaks cookies for the new registrant.

"Trust us, we will renew it" typically has similar odds to a coin flip, so we arrived at "2 years from today's date or longer" to give room for PR submitters to signal their commitment (and thus qualification for listing).

trabelsiemna8 commented 4 months ago

Short answer is Yep.

Most registries publish the expiration date in whois / rdap so that it can be looked up and not burn volunteer reviewer cycles.

Putting an entry in the PSL has a long term impact, so having an expiration date that is also long term helps signal from the requestor that they are committed to the domain(s) in the request.

Temporary entries are not acceptable. Domains can be renewed to an extended a period of up to 10 years. 10 seemed long. Many of us wanted 5, but we settled on 2.

Less time than that signals that the domain names might not renew and would leave debris for PSL maintainers and future registrant to deal with, which wastes a lot of time and causes problems for all involved except the one who requested the now-stale entry that breaks cookies for the new registrant.

"Trust us, we will renew it" typically has similar odds to a coin flip, so we arrived at "2 years from today's date or longer" to give room for PR submitters to signal their commitment (and thus qualification for listing).

Hello, thanks for the detailed explanation, I extended the domain registration strapiapp.com for 2 years. it will expire in November 2026, should it be ok to get the check passed?

simon-friedberger commented 3 months ago

@Baldinof The CI ran fine. Please update the initial request. Also, can you please elaborate which Cloudflare and Letsencrypt limitations you are working around?

Baldinof commented 3 months ago

@Baldinof The CI ran fine. Please update the initial request. Also, can you please elaborate which Cloudflare and Letsencrypt limitations you are working around?

Nice!

@simon-friedberger We are not working around cloudflare / letsencrypt, should I just remove the section?

simon-friedberger commented 3 months ago

If you're not working around any restrictions make the list empty but keep the task.

Baldinof commented 3 months ago

Alright, it's done.

Baldinof commented 3 months ago

Thank you @simon-friedberger :)