search

publicsuffix / list

The Public Suffix List
https://publicsuffix.org/
Mozilla Public License 2.0
1.93k stars 1.18k forks source link

tools/internal/parser: detect and report section markers within suffix blocks #2011

Closed danderson closed 2 weeks ago

danderson commented 3 weeks ago

Small extra validation that I remembered while I was implementing the big text/utf-8 bits that have now been merged.

Note this PR does not pass the tests in tools/internal/parser as-is, because it trips over the expired exemptions that get fixed in #2010. This doesn't break PSL CI right now since tools/internal/parser isn't run there, but I recommend merging #2010 first and then this. The two changes are touching different parts of the codebase, so they should rebase cleanly in either direction.

simon-friedberger commented 2 weeks ago

LGTM, I think it would be great to move to the stage where this checks sorting or automatically sorts!

danderson commented 2 weeks ago

Yup, that's the next change, I'm still fighting with Unicode but should have it tomorrow. It will involve some painful reordering or a bunch of exceptions though, there are ~50 blocks in the wrong order atm. I may be able to reduce that by the time I send the PR though.