publicsuffix / list

The Public Suffix List
https://publicsuffix.org/
Mozilla Public License 2.0
1.93k stars 1.18k forks source link

Merge WebPros domains in the same section #2013

Closed atoomic closed 2 weeks ago

atoomic commented 2 weeks ago

cPanel, Plesk are part of the same WebPros family merge all domains together as a single organization entry.

Also note that this change is dropping on purpose the wildcard for cprapid as this is not needed and we want to be able to store cookies on x.cprapid.com sub domain.

view comment from https://github.com/publicsuffix/list/pull/1957#issuecomment-2182709465

make test output

PASS: libpsl_icu_load_fuzzer
PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       common.o
  CC       test-is-public-all.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-public
  CCLD     test-is-public-all
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-builtin
  CCLD     test-registrable-domain
PASS: test-is-public-builtin
PASS: test-is-cookie-domain-acceptable
PASS: test-is-public
PASS: test-registrable-domain
PASS: test-is-public-all
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc
dnsguru commented 2 weeks ago

comment: Same Submitter as prior PR

atoomic commented 2 weeks ago

Thanks @dnsguru this is now fixed :-)

simon-friedberger commented 2 weeks ago

Thank you for this cleanup! Quick reminder: domains are supposed to keep a validity of >2y, that's is currently not the case for any of your old domains.

atoomic commented 2 weeks ago

Thanks for noticing that >2y issue, I will request to fix that, then update this PR once the update is performed.

Reported and tracked internally as https://servicedesk.webpros.com/hc/en-us/requests/21598

atoomic commented 5 days ago

@simon-friedberger the expiration time for the domains above are now >2yo as expected

> for d in cprapid.com pleskns.com wp2.host pdns.page plesk.page wpsquared.site; do echo -n "Domain $d: "; whois $d | grep Expiry; done
Domain cprapid.com:    Registry Expiry Date: 2030-05-16T21:16:20Z
Domain pleskns.com:    Registry Expiry Date: 2028-06-05T02:57:13Z
Domain wp2.host: Registry Expiry Date: 2030-04-04T23:59:59.0Z
Domain pdns.page: Registry Expiry Date: 2028-03-18T06:47:39Z
Domain plesk.page: Registry Expiry Date: 2028-03-18T03:06:27Z
Domain wpsquared.site: Registry Expiry Date: 2027-06-20T23:59:59.0Z