publicsuffix / list

The Public Suffix List
https://publicsuffix.org/
Mozilla Public License 2.0
2.05k stars 1.22k forks source link

tools/psltool: support for analyzing a github PR #2087

Closed danderson closed 2 months ago

danderson commented 2 months ago

Sorry for the radio silence, I returned to work and as predicted available time went down :(

With this change psltool check-pr 1234 does a differential validation of the PR, diffing against the target branch to report new issues.

Example output, running against currently open PR 2084:

> GITHUB_TOKEN=$(gh auth token) go run ./psltool check-pr 2084
Checked the following changed suffix blocks:
  "libp2p project" (lines 14117-14119)

file needs reformatting, run 'psltool fmt' to fix

Error: file has 1 error
exit status 1

The error is due to the preexisting sorting issues, I decided to not suppress that error since it should be rare once the initial re-sorting is complete (PR incoming for that shortly).