publicsuffix / list

The Public Suffix List
https://publicsuffix.org/
Mozilla Public License 2.0
2k stars 1.2k forks source link

chore: update contact info + revert wildcard change for `wdh.app` #2108

Closed wdhdev closed 3 weeks ago

wdhdev commented 3 weeks ago

Original PRs #2067 and #2094

I promise this will be the last PR for this domain, sorry about this!

Rationale / Reasoning

Rationale for inclusion is seen in the original PR #2067.

Reasons for changes:

DNS record

I have updated the _psl.wdh.app TXT record to point to this PR:

dig +short TXT _psl.wdh.app
"https://github.com/publicsuffix/list/pull/2108"

Tests

All tests passed.

simon-friedberger commented 3 weeks ago

Would you mind sharing what the issue with the wildcard is?

wdhdev commented 3 weeks ago

It considers 3rd level subdomains (e.g. www.wdh.app) as TLDs instead of the 2nd level (wdh.app) therefore sometimes causing issues with some services considering 3rd level subdomains as TLDs and not letting them be added to their service while only allowing 4th level tlds being considered domains themselves. (tl:dr; I misconsidered how wildcards are handled on the PSL)

simon-friedberger commented 3 weeks ago

It would be great if you could update the wiki docs and explain the issues you were having!