Update author-boxes.php

spichkaJohn commented 1 month ago

Description

Even I use publishpress_authors_load_style_in_frontend to define load logic to false, I still have css loaded, found the place where condition was missed.

Benefits

Not load front css when it is not needed.

Possible drawbacks

Maybe it can cause issues for users that used loaded css event publishpress_authors_load_style_in_frontend set to false on their side.

Checklist

[x] I have created a specific branch for this pull request before committing, starting off the current HEAD of development branch.
[x] I'm submitting to the development, feature/hotfix/release branch. (Do not submit to the master branch!)
[ ] This pull request relates to a specific problem (bug or improvement).
[ ] I have mentioned the issue number in the pull request description text.
[ ] All the issues mentioned in this pull request relate to the problem I'm trying to solve.
[x] The code I'm sending follows the PSR-12 coding style.

spichkaJohn commented 1 month ago

@ojopaul, ok, I see you already fixed this in https://github.com/publishpress/PublishPress-Authors/commit/48eef5981c70e49bca443833aabdcfaa7fb89bb3

All wp_add_inline_style should also be wrapped with this check, I guess.

ojopaul commented 1 month ago

Yes @spichkaJohn I was making a release and couldn't wait since the issue has been reported, what wp_add_inline_style are you referring to?

spichkaJohn commented 1 month ago

@ojopaul ,sorry, it is not relevant anymore, after updating to 4.7.1, both inline and external styles disappeared.

Thank you so much for such a quick fix and comments.

publishpress / PublishPress-Authors