search

publishpress / PublishPress-Future

This plugin was known as "Post Expirator", and now it is called "PublishPress Future".
https://wordpress.org/plugins/post-expirator/
7 stars 11 forks source link

PublishPress Future FREE Translation Updates v.4.0.3 #1003

Closed wocmultimedia closed 2 days ago

wocmultimedia commented 4 weeks ago

Hi @andergmartins , @stevejburge ,

Here's copy of PublishPress Future FREE Translation Updates v.4.0.3. I also updated the files on WP.org which are already all approved.

TranslationUpdates-FutureFREE-4.0.3.zip

stevejburge commented 4 weeks ago

@wocmultimedia Can I ask if you're checking the end result of these translations? Here's what I see in the Free version of Future Screenshot 2024-10-24 at 1 17 47 PM

stevejburge commented 4 weeks ago

Here's French: Screenshot 2024-10-24 at 1 19 50 PM

wocmultimedia commented 4 weeks ago

Hi, I translated what was inside the Pro language folder and the 3 languages I translate were already set with the missing translation. So I don't know what you mean. Tomorrow back in my office I make a new check. But I haven't understood the problem

24 Ott 2024 19:20:27 Steve Burge @.***>:

Here's French: Screenshot.2024-10-24.at.1.19.50.PM.png (view on web)[https://github.com/user-attachments/assets/33078d7d-0900-4cae-95c3-af7ed5c04cb9]

— Reply to this email directly, view it on GitHub[https://github.com/publishpress/PublishPress-Future/issues/1003#issuecomment-2435896333], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAR6I4APRS7APA3NHYT7EI3Z5ET5TAVCNFSM6AAAAABQRQQ5SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVHA4TMMZTGM]. You are receiving this because you were mentioned. [Immagine di monitoraggio][https://github.com/notifications/beacon/AAR6I4CJU24JNIF7JCPNPMDZ5ET5TA5CNFSM6AAAAABQRQQ5SWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTURGDKA2.gif]

stevejburge commented 4 weeks ago

@andergmartins @wocmultimedia It looks like we need a better way to check for missing strings

wocmultimedia commented 4 weeks ago

Hi, I saw there's something unusual. I opened the files inside the Pro and they are different of what I created. These are the files I created TranslationUpdates_PublishpressFuture-PRO-4.0.3.zip

But now inside the 4.04 I found wrong ES/FR/IT.po files. You mingles something during your check. mingledfilesoftranslations.zip

As well as I saw that you reinstated these file type again into the language folder that weren't present in 4.0.3 publishpress-future-pro-es_ES-future_workflow_editor_script.po

You made a mess. I checked these file types you reinstated and are the old ones while the new ones are inside the Future Free. In fact if do you open these files in the Pro 4.04 they are 187 in total but 74 to be translated have a look FilesReinstatedbyYounowin4.04.zip

While inside the Future Free translations I sent you there are the same files with 187 strings full translated see TranslationUpdates-FutureFREE-4.0.3.zip

Furthermore the strings in file .pot are 65 while what I translated were 73 and they were ready with 16 strings to be translated.

I suggest that you take a deep breath and check carefully what happened during your process. Thanks.

wocmultimedia commented 4 weeks ago

Hi @andergmartins , @stevejburge ,

Besides what I wrote in my previous comment, this morning I opened the ES/FR/IT.po files inside languages folder of Future FREE latest 4.0.4 release and I found another mess. ES.po is and older version not full translated. with huge string quantity. FR/IT.po are older files with lesser strings than .pot file ES/FR/IT...future_workflow_editor_script.po are older not completed translation version before my latest translation.

At first sight you made some changes and used part of the files included in the version prior the 4.0.3. In any case didn't make use of my latest translation.

stevejburge commented 3 weeks ago

Thanks @wocmultimedia. We'll get this sorted out

wocmultimedia commented 3 weeks ago

Hi, Maybe this can help you. I created the languages folder for both FREE and PRO with my translation of 4.0.3 and the structure you made in the 4.04. Only json files are missing.

Language folder for FREE including the ES/FR/IT languages if it works you can use it as reference for other languages. Only json files are missing. LanguageFolder-FutureFREE.zip

Language folder for PRO including the ES/FR/IT languages if it works you can use it as reference for other languages.Only json files are missing. LANGUAGES-FOLDER-for-FUTURE-PRO.zip

andergmartins commented 2 weeks ago

Thanks @wocmultimedia, sorry for the mess, I will check what happened

andergmartins commented 2 weeks ago

@wocmultimedia regarding translations for JS files, do you feel like having all the terms in a normal .po file makes more sense or would it make things easier for you instead of having them in .json files?

wocmultimedia commented 2 weeks ago

@andergmartins , @stevejburge , If all terms are in the po files it's better than having different files type. Besides the json files as required by wp seems different than normal one if I'm not wrong. Anyway the important is to know which files have to be translated to make the plugin full localized. I will adapt to your solution but po file are easier to edit with poedit.

andergmartins commented 2 weeks ago

@wocmultimedia I'm still working on this, but we are moving this to 4.1.1. We are about to release 4.1.0, and you can ignore it for now since the translations are not fixed there yet. We can keep working on fixing/updating the translations on 4.1.1 and higher versions.

wocmultimedia commented 2 weeks ago

@andergmartins I will check the new release to see what is going on and if there's something broken inside. Then I will update WP.org files

andergmartins commented 6 days ago

@wocmultimedia I submitted a few changes addressing translations.

I've removed the script that automatically updated the .po files, so we are not touching them anymore.

Regarding translations to JavaScript files, unfortunately for better performance and WP's good practices compliance, I would not be able to merge all the strings from both .js and .PHP sides in the same file.

We will need to deal with two .pot files, and different .po files for JavaScript and PHP files.

Considering we are always working on translations as a fix for already released packages, I suggest we follow the following workflow for every release, but I would like to hear your thoughts:

Does that make sense?

wocmultimedia commented 6 days ago

@andergmartins Regarding json files there's no problem. You can create as much as .pot file needed. Just let me know in advance if do you like to release the version complete or otherwise go on as usual but just refresh the various .pot files. When I receive the communications I will translate the .po files according to .pot files I will find inside languages folder.