publishpress / PublishPress-Revisions

Moderate, schedule and compare changes to published WordPress content.
https://publishpress.com/revisionary/
6 stars 8 forks source link

Can we add more "Approve" buttons #1330

Open stevejburge opened 2 weeks ago

stevejburge commented 2 weeks ago

Can we give users more ways to approve a revision?

In the admin bar: Screenshot 2024-09-13 at 10 22 17 AM

On the Revisions screen: Screenshot 2024-09-13 at 10 22 09 AM

agapetry commented 1 week ago

@stevejburge "Publish Now" is already an Approve button in the top bar.

stevejburge commented 1 week ago

Thanks @agapetry. Is that a little different? "Publish Now" means publish right now. "Approve" means approve for future publication?

agapetry commented 1 week ago

Approve is the more general term, meaning either publish it now or schedule it, depending on the stored (requested) publication date. It is used in this general sense in the bulk edit function, so that selected revisions will be either published or scheduled:

image

If you instead apply the bulk action of "Publish", that will cause all selected revisions to be published immediately, regardless of their stored date or scheduling status.

If the stored publication date is not future, there is no distinction between "Approve" and "Publish." In theory, the plugin could implement an "Approved" status as an intermediate condition between Submitted Revision and Published Revision, but that would require some retraining and likely support calls because "Approve" has never before meant that to this plugin.

agapetry commented 1 week ago

There is also a layout consideration. For many browser scenarios, adding another row action would force all the rows in the Revision Queue table to be taller by one row. Is that worth the dubious convenience of being able to approve a revision sight unseen?

image

stevejburge commented 1 week ago

Thanks @agapetry. On the frontend, should we change "Publish Now" to "Approve"?

I'm OK with keeping the button off the admin row.