search

publishpress / PublishPress-Statuses

PublishPress Statuses
GNU General Public License v3.0
1 stars 0 forks source link

Pending status draggable to Disabled even though disabling is prevented #85

Closed stevejburge closed 10 months ago

stevejburge commented 10 months ago

It appears that it's impossible to disable Pending Review. Even when disabled in PublishPress Statues, it still appears: Screenshot 2023-12-14 at 12 44 26 PM Screenshot 2023-12-14 at 12 45 20 PM

Should we treat "Pending Review" like "Draft", as a special case that can't be disabled?

agapetry commented 10 months ago

@stevejburge It cannot be disabled due to hardcoded WordPress behavior. If you refresh the Statuses page after dragging Pending to the Disabled section, you'll see that the disable is not actually applied. That's intentional, as is the lack of "Disable" action link in the Pending row. I just need to adjust the table js to visibly reject the drag.

stevejburge commented 10 months ago

@agapetry Thanks. I agree. Let's treat it just like "Draft"

agapetry commented 10 months ago

@stevejburge I can't treat it just like draft because the ability to adjust the workflow order is important.

agapetry commented 10 months ago

@stevejburge I have the fix for this ready to go.

stevejburge commented 10 months ago

Great, thanks @agapetry