search

publons / ojs_3_plugin

OJS3 Plugin for the export of reviews to Publons
7 stars 6 forks source link

fix Publons plugin for OJS3.3.0-6 #12

Closed huifeidepangzi closed 3 years ago

huifeidepangzi commented 3 years ago

Test

image

image

image

image

image

huifeidepangzi commented 3 years ago

All of these looks great to me, Yi. My only worry would be whether these changes are backwards compatible or not. Can we do a run through some of the release versions and make sure the plugin still works? Seems like we're making things work on the latests OJS version but I'm not convinced this would work for previous versions?

Hi Joao, thanks for the review. Yes it won't compatible with the old OJS env, the main reason for this is that the OJS earlier than 3.2 won't support getInstallMigration (don't have this function definition in the base class), whereas the OJS later than 3.3 won't support getInstallSchemaFile (they add final keyword for this function so we can not leave the function definition in the class anymore).

joopeed commented 3 years ago

So are we happy to drop support for these previous versions?

huifeidepangzi commented 3 years ago

So are we happy to drop support for these previous versions?

We won't drop the supported of previous version, we still have them, we add a new release to support the new OJS version image

joopeed commented 3 years ago

But the new version only supports 3.3 or later, right?

huifeidepangzi commented 3 years ago

But the new version only supports 3.3 or later, right?

yes, the code can not be compatible for earlier OJS version because of the way OJS change their code