pubnub / go

PubNub clients for Go
Other
102 stars 62 forks source link

Fix edge case when filesPayload message is nil #116

Closed crimsonred closed 2 years ago

crimsonred commented 2 years ago

fix(Fetch): fix paged history

Fix edge case in Fetch response when filesPayload message is nil.

codecov-commenter commented 2 years ago

Codecov Report

Merging #116 (782d9fb) into master (ceb3da6) will decrease coverage by 2.76%. The diff coverage is 74.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   80.84%   78.07%   -2.77%     
==========================================
  Files          62       72      +10     
  Lines        6953     8398    +1445     
==========================================
+ Hits         5621     6557     +936     
- Misses       1156     1600     +444     
- Partials      176      241      +65     
Impacted Files Coverage Δ
request_workers.go 80.85% <ø> (ø)
subscription_manager.go 74.49% <ø> (-1.25%) :arrow_down:
telemetry_manager.go 87.04% <ø> (-9.71%) :arrow_down:
time_request.go 77.14% <ø> (-1.65%) :arrow_down:
token_manager.go 100.00% <ø> (+21.12%) :arrow_up:
fire_request.go 69.78% <33.33%> (-2.07%) :arrow_down:
publish_request.go 78.87% <37.50%> (-0.56%) :arrow_down:
grant_common.go 57.30% <40.74%> (-10.83%) :arrow_down:
add_channel_channel_group_request.go 83.33% <50.00%> (-1.81%) :arrow_down:
add_channels_to_push_request.go 80.64% <50.00%> (-1.38%) :arrow_down:
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f66c2d...782d9fb. Read the comment docs.

crimsonred commented 2 years ago

@client-engineering-bot release

github-actions[bot] commented 2 years ago

🚀 Release successfully completed 🚀