search

pubnub / go

PubNub clients for Go
Other
102 stars 62 forks source link

Subscription manager should respond with complete PNStatus #136

Open gvaibhav1734 opened 1 year ago

gvaibhav1734 commented 1 year ago

PNStatus not populated completely

https://github.com/pubnub/go/blob/a2c70fc930c8a5225a998365c5774d3be3983d21/subscription_manager.go#L336

Why are we ignoring the PNStatus returned by executeRequest here?

executeRequest has full context of the API response and returns a fully populated PNStatus which is ignored and it is then being recreated minimally with only PNStatus.Category information.

Solution

We should either be passing the returned response from executeRequest or construct the PNStatus fully.