search

pubnub / haskell

PubNub Haskell SDK
Other
19 stars 16 forks source link

Change base64 ByteString usages to Text to work with aeson 0.7.0, which ... #3

Closed copumpkin closed 10 years ago

copumpkin commented 10 years ago

...doesn't have To/FromJSON instances for ByteStrings anymore.

copumpkin commented 10 years ago

Seems unfortunate to have to decode into Text only to encode again... this should work for now but I don't really like it. Also, why do we attempt to decode JSON and then return the input if it fails?

copumpkin commented 10 years ago

Gah, forgot github pull requests are mutable. Didn't mean to include the other commit in this, but it might be okay. Let me know if you want me to split them up.

tsloughter commented 10 years ago

Na, together is fine. Changes look good, trying locally before merging. Thanks!

As for the decode json failing and return the input, are you referring to decodeJson in Pubnub.hs? I don't remember why that is like that, and good chance it was a spot I meant to go back and add error handling but forgot :).

copumpkin commented 10 years ago

Thanks!