search

pubnub / javascript

PubNub JavaScript SDK docs https://www.pubnub.com/docs/sdks/javascript
Other
553 stars 401 forks source link

@types/pubnub for 5.x #263

Open k-funk opened 2 years ago

k-funk commented 2 years ago

Is it correct to assume that pubnub maintains typings in the DefinitelyTyped repo? If so, it would be great to have the version numbers match up.

Reference: @mohitpubnub https://github.com/DefinitelyTyped/DefinitelyTyped/commits/master/types/pubnub/index.d.ts

Perhaps related, or perhaps it's intentionally left out: interface StatusEvent { is missing the statusCode prop. I was expecting to see it there, to at least log 403s that come through.

lauralouiset commented 2 years ago

I've also found some inconsistencies with typing... specifically in version 7.2.0, fetchMessages returns a FetchMessagesResponse, though if you set includeMessageActions to true you get a 'more' property which is not mentioned in the FetchMessagesResponse type.

mohitpubnub commented 1 year ago

To address said issues, PR is created at DefinitelyTyped. This issue will be closed once the updated types will be published.

Thank You @k-funk and @lauralouiset for bringing the attention. Sorry for the delay!