Create Ember CLI addon - Githubissues

pubnub / pubnub-ember

PubNub Ember SDK

http://pubnub.github.io/pubnub-ember

Other

14 stars 3 forks source link

Create Ember CLI addon #1

Open Ghostavio opened 10 years ago

Ghostavio commented 10 years ago

This is already really awesome, and it would be cool to have an ember-cli addon as they released this feature recently and it significantly reduces installation time. Is this in the roadmap?

Thanks :)

stephenlb commented 10 years ago

Good call!

stephenlb commented 10 years ago

@sunnygleason wdty?

sunnygleason commented 10 years ago

@Ghostavio this is a great idea - I met up with @bcardarella at the EmberJS meetup last month, and he gave me some great pointers on how to get started. Stay tuned in the next couple months!

ultimatemonty commented 9 years ago

+1 on this! any updates on progress?

nakardo commented 9 years ago

+1!

nakardo commented 9 years ago

Apart from adding support for this. Have anyone in the meantime been able to make it work on a Ember CLI based project?

ultimatemonty commented 9 years ago

All,

I contacted PubNub support about the EmberCLI addon and as of this time there are no plans for an Ember-CLI addon. If demand increases they will pursue it.

Is anyone interested in taking on the effort to convert this to an unofficial addon? The blueprint for what we need is already in the existing code - we'd just need to repackage it as an addon? Hit me up at ultimatemonty at gmail dot com or [at]ultimatemonty on Twitter if anyone is interested.

akisvolanis commented 9 years ago

ultimatemonty commented 9 years ago

For anyone still wanted to use with Ember-CLI I managed to get it working with 0.1.15. Here's a gist with all the changes.

Basically I broke the PubNub-Ember lib out into the relevant bits and pieces like CLI wants them. 99.99999% of the code stayed the same.

Install the pubnub JS client with bower and import in your Brocfile. DO NOT INSTALL PUBNUB-EMBER

bower install --save pubnub

Config moved from extending the PubNubEmber controller to environment.js. Relevant code
Changed the main Pubnub-Ember lib from an ObjectController to a Service. Had to import the environment file and change some references in the init method to make it work. Relevant code
Break the initializer out into it's own file and make sure to import the service

Works great now! Not ideal but it'll certainly get the job done. Next step is breaking this out into an addon.

stephenlb commented 9 years ago

Thank you Chris!

probabble commented 8 years ago

+1 would love to use this in an ember-cli project

jrdn91 commented 8 years ago

http://emberobserver.com/addons/ember-cli-pubnub

I've been using it for a while, it's been working well so far!

villander commented 8 years ago

@Jordan4jc i saw you addon, is a good start. But it is very inconsistent, because you have a service that loads the pubnub, and time to implement a messenger with pubnub API, the only option is to do this in a component or controller. Since the right way is to abstract it to a service and implement your messenger it. Staying with pubnub coupled in controller or component is a horrible practice.

Following the guides, services is made to wrapper Third-party APIs and Server-sent events or notifications. https://guides.emberjs.com/v2.4.0/applications/services/

mervinva commented 7 years ago

Is there any ember-cli addon for pubnub ?