search

pubnub / rust

PubNub Rust SDK.
Other
30 stars 8 forks source link

ref/minor-log #124

Closed mohitpubnub closed 1 year ago

mohitpubnub commented 1 year ago

@Xavrax seems like since we have a better error handling in place, not thinking of adding additional logs explicitly as too verbose log also make it hard to troubleshoot.

Have gone through error cases and it seems out API error is giving very precise information to figure out issue. E.g: image

mohitpubnub commented 1 year ago

log our config at the beginning of the process

the thought was, since the url was prepared at send method and it contains all required component. while troubleshooting this one line log would give all required info to us. However which place do you suggest would be more suitable for this info to be logged at.? Do you think of it at build()?

also we don't worry about having pub/subkey in logs. Other sdk logs have it- I'm sure about js. , since these logs meant to be sent to us only.

Xavrax commented 1 year ago

discussed at DM