pubpub-zz / ppInk

Fork from Gink
MIT License
842 stars 76 forks source link

Discrepancies with icons on toolbar #229

Closed PeteCrowe closed 6 months ago

PeteCrowe commented 1 year ago

Sorry to add to your workload...but maybe I'm just not understanding the Move | Copy | Scale | Rotate | Pan tool. The title of the tool seem to have nothing to do with what I can achieve with them.

First, the MCSRP tool. MCSRP graphic

While the tooltip lists 5 different actions, only 3 icons appear, all of which deal with moving items. There is no apparent Scale, Rotate or Pan functions.

The "ScaleRot" tool actually functions, allowing one to Scale and Rotate a graphic, but the tooltips read "Move one Stroke/Group" and "Copy one Stroke/Group"...the tooltips accidentally taken from the Move tool? Copy and paste can be our friend, until it isn't. :-) SR graphic

pubpub-zz commented 1 year ago

Thanks for the report. the tools are (Move | Copy | Pan) and (Scale | Rotate). This version fixes this (also includes the other fixes already committed) ppInk_hints.zip

pubpub-zz commented 1 year ago

@PeteCrowe Can we consider this as closed ?

PeteCrowe commented 1 year ago

My apologies for not responding sooner. There are still issues, some related to the tooltips, others that I've newly discovered, but still relevant to the Move | Copy | Pan (P) and Scale | Rotate (S) tools.

When in the Scale | Rotate tool, with the two tool fly-out displayed, the ToolTips over the Scale and Rotate tool are incorrect, displaying the tool tips from the P tool instead of the S tool (see image). In addition, if I have that tool fly-out displayed from the S tool, and I want to change tools, say doing a mouse click on the P tool, the tool pop-out does not change to reflect the change of tool. Clicking the P tool still displays the S tool pop-out. This only applies to the P and S tools. If I have the S tool fly-out displayed, and I attempt to click on the Rectangle (R) tool, the fly-out NOW updates and displays all the variations of the R tool.

Thank you! Happy Holidays.

screencap

pubpub-zz commented 1 year ago

a copy/paste error : should be good ppInk fix ScaleRot Hint.zip

Note : this beta also includes a new feature "Extra Pens"

PeteCrowe commented 1 year ago

All of the tool tip and flyout issues have been resolved. But now, there is a blank space under the custom pens (I use my menu vertically). Also, I can't access the options dialog anymore. Right clicking brings up a drawing tool and results in pen marks. If this is because it's a beta, then so be it. ppInk new toolbar

pubpub-zz commented 1 year ago

The extrapens option was not implemented correctly with vertical toolbar ppInk extraPens Vert.zip

PeteCrowe commented 1 year ago

This now works and the original bug can be closed. Many thanks for your diligence and hard work.