search

pubsubhubbub / php-subscriber

A PubSubHubbub subscriber module for PHP
https://packagist.org/packages/pubsubhubbub/subscriber
Apache License 2.0
33 stars 18 forks source link

Give a default value to the param $post_string in http() #13

Closed karptonite closed 7 months ago

karptonite commented 7 months ago

Hey, thanks for updating PHP version requirements. I wasn't able to test all of the functionality live (our code doesn't use all of the features of this library), but I did use PHPStan to statically analyze the code--it should catch most of what would be an issue for PHP 8. This pull request is a fix for the only issue it found:

The private function http() is called with and without the $post_string parameter; I added a default value of false to indicated that.

If this looks good and is merged, it would also be helpful if you could also do a new release to Packagist. Thanks for your work on this!

maksverver commented 7 months ago

Thanks Daniel. I've merged the pull request. I'm not a maintainer on Packagist, so I can't do anything there, but it looks like the package is configured to auto-update, so I'll try to create a new release in hopes that will cause the Packagist version to update as well.

karptonite commented 7 months ago

Thanks so much!