Bug|user registration|Litigant and Advocate| Internal Testing|

Susmitabe commented 3 weeks ago

Describe the bug

Building name and door number should not be mandatory in user registration - change the address field

To Reproduce Steps to reproduce the behavior:

Go to '.User registration..'
Click on 'after filling details dont fill the building name and door number....'
See error- Won't be able to proceed further without filling the details.

Expected behavior Should be able to go to next page without filling Building name and door number

Screenshots

https://github.com/user-attachments/assets/f2d7bf7c-9b87-438f-8bd8-0f7dc820d8f7

Susmitabe commented 1 week ago

Clarification - Since the user may not be staying in building or might not have a door number. Hence, keep the building name & door number optional @ashishbeehyv . To all places where address is needed.

ashishbeehyv commented 1 week ago

hi @bhuvanyuguru i have merged the changes for this ticket in dev. Please test this. cc: @Ramu-kandimalla

bhuvanyuguru commented 1 week ago

Hi @ashishbeehyv , @Ramu-kandimalla this bug is fixed in DEV.

Attaching video for reference.

test door number.webm

Beehyv-Vinod commented 4 days ago

Tested in Kerala-qa, Both the fields are working as Mandatory --https://jam.dev/c/e9b7e724-99f8-4717-b0b4-414403bd3c60

Beehyv-Vinod commented 2 days ago

Tested in Kerala-qa, Both fields are working as Optional --https://jam.dev/c/1d14ca24-0ccf-4136-8b77-18012f9405ad, But User is not able to register himself as create API is failing with 400 bad request.

cURL

curl 'https://dristi-kerala-qa.pucar.org/individual/v1/_create?tenantId=kl&_=1729254762194' \ -H 'authority: dristi-kerala-qa.pucar.org' \ -H 'accept: application/json, text/plain, */*' \ -H 'accept-language: en-GB,en-US;q=0.9,en;q=0.8' \ -H 'content-type: application/json;charset=UTF-8' \ -H 'cookie: _dd_s=logs=1&id=71eab97b-7026-4600-a0e1-c55be7e9e285&created=1729254138463&expire=1729255662186' \ -H 'origin: https://dristi-kerala-qa.pucar.org' \ -H 'referer: https://dristi-kerala-qa.pucar.org/digit-ui/citizen/dristi/home/registration/terms-condition' \ -H 'sec-ch-ua: "Not_A Brand";v="8", "Chromium";v="120", "Google Chrome";v="120"' \ -H 'sec-ch-ua-mobile: ?0' \ -H 'sec-ch-ua-platform: "Linux"' \ -H 'sec-fetch-dest: empty' \ -H 'sec-fetch-mode: cors' \ -H 'sec-fetch-site: same-origin' \ -H 'user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36' \ --data-raw '{"Individual":{"tenantId":"kl","name":{"givenName":"Complainant"},"userDetails":{"username":"7777777771","roles":[{"code":"CITIZEN","name":"Citizen","tenantId":"kl"},{"code":"CASE_CREATOR","name":"CASE_CREATOR","tenantId":"kl"},{"code":"CASE_EDITOR","name":"CASE_EDITOR","tenantId":"kl"},{"code":"CASE_VIEWER","name":"CASE_VIEWER","tenantId":"kl"},{"code":"DEPOSITION_CREATOR","name":"DEPOSITION_CREATOR","tenantId":"kl"},{"code":"DEPOSITION_VIEWER","name":"DEPOSITION_VIEWER","tenantId":"kl"},{"code":"APPLICATION_CREATOR","name":"APPLICATION_CREATOR","tenantId":"kl"},{"code":"APPLICATION_VIEWER","name":"APPLICATION_VIEWER","tenantId":"kl"},{"code":"HEARING_VIEWER","name":"HEARING_VIEWER","tenantId":"kl"},{"code":"ORDER_VIEWER","name":"ORDER_VIEWER","tenantId":"kl"},{"code":"SUBMISSION_CREATOR","name":"SUBMISSION_CREATOR","tenantId":"kl"},{"code":"SUBMISSION_RESPONDER","name":"SUBMISSION_RESPONDER","tenantId":"kl"},{"code":"SUBMISSION_DELETE","name":"SUBMISSION_DELETE","tenantId":"kl"},{"code":"TASK_VIEWER","name":"TASK_VIEWER","tenantId":"kl"},{"code":"CASE_RESPONDER","name":"CASE_RESPONDER","tenantId":"kl"},{"code":"HEARING_ACCEPTOR","name":"HEARING_ACCEPTOR","tenantId":"kl"}],"type":"CITIZEN"},"userUuid":"ee2cbe01-3085-421b-8579-b2a70a71893a","userId":247,"mobileNumber":"7777777771","address":[{"tenantId":"kl","type":"PERMANENT","latitude":17.4549784,"longitude":78.3500765,"city":"Kondapur","pincode":"500032","addressLine1":"Telangana","addressLine2":"Rangareddy","street":"F84X+5MQ","doorNo":"","buildingName":""}],"identifiers":[{"identifierType":"PAN_CARD","identifierId":"390a4a52-2d05-4d23-8bab-04b54da5039a"}],"isSystemUser":true,"skills":[],"additionalFields":{"fields":[{"key":"userType","value":"LITIGANT"},{"key":"userTypeDetail","value":"{\"code\":\"LITIGANT\",\"name\":\"LITIGANT_TEXT\",\"showBarDetails\":false,\"isVerified\":false,\"role\":[\"CASE_CREATOR\",\"CASE_EDITOR\",\"CASE_VIEWER\",\"DEPOSITION_CREATOR\",\"DEPOSITION_VIEWER\",\"APPLICATION_CREATOR\",\"APPLICATION_VIEWER\",\"HEARING_VIEWER\",\"ORDER_VIEWER\",\"SUBMISSION_CREATOR\",\"SUBMISSION_RESPONDER\",\"SUBMISSION_DELETE\",\"TASK_VIEWER\",\"CASE_RESPONDER\",\"HEARING_ACCEPTOR\"],\"subText\":\"LITIGANT_SUB_TEXT\"}"},{"key":"termsAndCondition","value":true},{"key":"identifierIdDetails","value":"{\"fileStoreId\":\"390a4a52-2d05-4d23-8bab-04b54da5039a\",\"filename\":\"1MB.pdf\"}"}]},"clientAuditDetails":{},"auditDetails":{}},"RequestInfo":{"apiId":"Rainmaker","authToken":"ebd8e9c6-512d-49d1-b1f9-fa8846130789","msgId":"1729254762194|en_IN","plainAccessRequest":{}}}' \ --compressed

Response

{ "ResponseInfo": null, "Errors": [ { "id": null, "parentId": null, "code": "Size.individualRequest.individual.address[0].doorNo", "message": "size must be between 1 and 64", "description": null, "params": null }, { "id": null, "parentId": null, "code": "Size.individualRequest.individual.address[0].buildingName", "message": "size must be between 2 and 256", "description": null, "params": null } ] }

Beehyv-Vinod commented 2 days ago

Hi @Ramu-kandimalla @rajeshcherukumalli Tested in Kerala-qa, Both fields are working as Optional--https://jam.dev/c/43bceb68-793a-4653-a91c-ff2ae5217ad7 & User is able to register himself without encountering the any issues

pucardotorg / dristi

Bug|user registration|Litigant and Advocate| Internal Testing| #1743