search

pucardotorg / dristi

MIT License
2 stars 12 forks source link

Application Numbering #2179

Open Ramu-kandimalla opened 1 month ago

Ramu-kandimalla commented 1 month ago

Requirement Scope: Application Numbering.pdf

atulgupta2024 commented 1 month ago

this will require changes to case summary API https://github.com/pucardotorg/dristi/issues/2223

@suresh12 @Ramu-kandimalla @manimaarans

manimaarans commented 4 weeks ago
nileshgupta111 commented 3 weeks ago

Tested in dev and it will be pushed to qa along with all other changes in develop

iknoorkaur commented 2 weeks ago

Hi @rajeshcherukumalli : Attaching the test cases https://docs.google.com/spreadsheets/d/1z_k37XuZ7ukn57uscGD30gb5of6NsYXrfQKiWYQVW2o/edit?pli=1&gid=0#gid=0 cc : @Ramu-kandimalla

iknoorkaur commented 2 weeks ago

Hi @Ramu-kandimalla, Tested in DPG-DEV env, working fine as expected: image cc: @rajeshcherukumalli

atulgupta2024 commented 1 week ago

@manimaarans here are the final requirements

  1. Application should be assigned a number (CMP Format) after is signed and paid for i.e. when it is in PENDING_APPROVAL state.
  2. Application Number will be null when the application is created
  3. In the Submission TAB on UI, "Submission ID" will remain blank, if the application Number is null

@Ramu-kandimalla @suresh12 @Susmitabe @Taherabharmal FYI as well.

manimaarans commented 1 week ago

@manimaarans here are the final requirements

  1. Application should be assigned a number (CMP Format) after is signed and paid for i.e. when it is in PENDING_APPROVAL state.
  2. Application Number will be null when the application is created
  3. In the Submission TAB on UI, "Submission ID" will remain blank, if the application Number is null

@Ramu-kandimalla @suresh12 @Susmitabe @Taherabharmal FYI as well.

  1. not all applications go through payment, and also not all applications have the pending approval state, So need more clarity on when cmp number needs to be generated across different workflows

  2. The application number is used for workflow business service, and payment. Might be having cascading issues as the application number is primarily used for querying applications can we introduce a new applicationCmpNumber field, so it can be kept null and generated after conditions are met for number generation? so the only changes we might need to make is to identify all places where we need to use cmp and use this field in that place?

    cc: @Ramu-kandimalla @rajeshcherukumalli @vaibhavct @anirudh-0

manimaarans commented 1 week ago

as per discussion 1..only voluntary submission and delay condonation will get CMP number when they reach pending approval State.
2.Delay condonation in pending approval state won't come up as open application in causelist pdf . @Taherabharmal @devarajd94 Please confirm this 3.Delay condonation will get CMP number before the case gets CMP number

cc: @atulgupta2024 @nileshgupta111 @Ramu-kandimalla

nileshgupta111 commented 1 week ago

@atulgupta2024 what should be the applicationNumber on create for voluntary submission cc @manimaarans @Ramu-kandimalla

manimaarans commented 1 week ago

Hi @atulgupta2024 for application number generation we will generate based filing number before cc: @nileshgupta111

iknoorkaur commented 1 week ago

Hi @nileshgupta111, The CMP No for Delay condonation and voluntary submissions is not coming when it is in 'Pending review' and 'completed' stage. image

cc : @rajeshcherukumalli @Ramu-kandimalla

nileshgupta111 commented 1 week ago

@iknoorkaur It will only be generated once it reaches PENDINGAPPROVAL state . else it will be null

iknoorkaur commented 1 week ago

Hi @Ramu-kandimalla , Tested in dpg-dev, the following below scenarios:

  1. Verified that the CMP number appears for voluntary submissions when the case is in the "pending approval" stage.
  2. Confirmed that the CMP number is displayed for voluntary submissions when the case is in "completed/rejected" status if it passed through the "pending approval" stage.
  3. Ensured the CMP number does not appear for voluntary submissions in "completed/rejected" status if the case did not go through the "pending approval" stage.
  4. Observed that the CMP number is present for "delay condonation" submissions after the case is registered https://github.com/pucardotorg/dristi/issues/2424 https://github.com/pucardotorg/dristi/issues/2428
  5. Confirmed that the CMP number should not appear for mandatory submissions https://github.com/pucardotorg/dristi/issues/2425

cc : @rajeshcherukumalli

iknoorkaur commented 4 days ago

Hi @Ramu-kandimalla Tested in UAT env and working as expected: Image cc : @rajeshcherukumalli

atulgupta2024 commented 3 days ago

@manimaarans had pointed out that workflow server is using application number. hence we cannot keep it null. when an application is created, it will get an application number ( application number format as per earlier implementation).

then at the time of pending approval, it will get a new CMP number. This will also be stored in a new field - cmpNumber. The UI will use this field to display. the applicationNumber field will be used to manage the workflow service