search

pucardotorg / dristi

MIT License
2 stars 12 forks source link

[BUG]: HRMS UI does not show a department in the dropdown #2255

Open subhashini-egov opened 1 month ago

subhashini-egov commented 1 month ago

Describe the bug An employee cannot be created via the HRMS UI without a department assignment. Currently, department dropdown shows "No options" and therefore, the "SUBMIT" button is greyed out.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://dristi-kerala-uat.pucar.org/workbench-ui/employee/
  2. Enter a HRMS Admin user or super user credentials and click on "LOGIN"
  3. Click on the HRMS card in the UI and click on "Create Employee"
  4. In the create screen, click on the Department dropdown. It shows "No options".

Expected behavior

The department master should be loaded from common-masters or egov-hrms masters. These are not configured in the DB currently. Hence this problem.

**Screensho

Screenshot 2024-10-24 at 11 57 14 AM

ts**

Fix Check the MDMS schema to ensure HRMS masters are configured in MDMS v2. If not, add the department and designation masters to MDMS v2 and load appropriate data. @Taherabharmal can you please provide the values for department and designations for HRMS.

subhashini-egov commented 1 month ago

@shashikesh12 - Please refer to this document here for reference. You can also ping @aaradhya-egov for some clarification.

subhashini-egov commented 1 month ago

You can reach out to me in case you need clarifications. Please check if the appropriate masters are loaded in MDMS v2. @shashikesh12

shashikesh12 commented 1 month ago

@subhashini-egov i checked the API call that we are making from that page and we are getting data there from backend, but that's not coming up as part of dropdown. So added UI Label to it.So, someone from UI team can investigate on it.

atulgupta2024 commented 4 weeks ago

@shashikesh12 can you point out to what are the values, because I could not find the right department vales in MDMS data being inserted via script as shared by @anirudh-0 (https://github.com/pucardotorg/pucar-DevOps/blob/Solutions-Pipeline/deploy-as-code/charts/backbone-services/postgresql/init-scripts/uat.sql)

it rather has eGov's PGR data which should be removed.

@subhashini-egov @manimaarans @suresh12 @Ramu-kandimalla

shashikesh12 commented 4 weeks ago

@atulgupta2024 this is the data we are getting and these are same as it's there in script that you mentioned in above comment Screenshot from 2024-10-28 10-38-48

Ramu-kandimalla commented 4 weeks ago

Hi @Taherabharmal Can you please share the MDMS data

ashishbeehyv commented 3 weeks ago

hi @rajeshcherukumalli this issue is fixed. can you please test it. cc: @Ramu-kandimalla

kashish384 commented 3 weeks ago

Its working as expected.

subhashini-egov commented 3 weeks ago

@kashish384 @Ramu-kandimalla - https://docs.google.com/spreadsheets/d/1FnqPw9iBYr12K-eMY-urPC2t7AHZvw1ceORkSPekQWw/edit?usp=sharing -- Masters for HRMS should be loaded from this sheet. Only use what is marked in green. EmployeeType, Department, Designations need to be updated. Can you please let me know if you need another ticket for this?? This is not yet done.

subhashini-egov commented 3 weeks ago

@Taherabharmal please update this ticket here if there are changes. Thanks.

kashish384 commented 2 weeks ago

Hi @shashikesh12 , look on this, its not working as expected. https://jam.dev/c/42c049c0-924a-48d6-8b32-b9a9f64bbc54

shashikesh12 commented 1 week ago

@Ramu-kandimalla @subhashini-egov master data is updated according to all green entries in master data sheet that's shared above

kashish384 commented 1 week ago

Its working fine in QA[sol env.

kashish384 commented 1 week ago

Its working fine in UAT env. https://jam.dev/c/01e93098-0a99-4384-a0e6-96cc8843eef2