pucardotorg / dristi

MIT License
2 stars 12 forks source link

PROD Hotfix: Multiple advocates during e-filing and related payment #2507

Open atulgupta2024 opened 1 day ago

atulgupta2024 commented 1 day ago

Changes required

  1. During e-filling, a complainant can specify - "Number of Advocates". A place holder will be added where the red box is shown in the figure below. The default value will be one, with a validation that it cannot go below 1.

image

  1. It is currently expected that only 1 vakalatnama will be uploaded for all, so no change in that logic.
  2. The screen will have an added info box (green place holder), with the following text

Only advocate added here will have access and the ability to sign the case. Payment for case, in particular the advocate welfare fund, will be calculated based on the number of advocates.

  1. Based on the number of advocates specified, update the payment logic to the one mentioned below. Essentially the Advocate welfare fund logic will change. The billing already has a head for "Advocate welfare fund". Just update the final amount there.
  2. The advocate clerk welfare fund logic is already in place. no change to that.

Current logic Vakalathnama Fee = INR 6, Advocate Welfare Fund = INR 25 Advocate Clerk’s Welfare Fund = INR 12

Updated logic Advocate Welfare Fund = If 1 Adv. = Rs. 25 If 2 Adv. = Rs. 50 If 3 or more Adv. = Rs. 75

Vakalathnama Fee = INR 6 Advocate Clerk’s Welfare Fund = INR 12

@suresh12 @Taherabharmal

atulgupta2024 commented 1 day ago

The info box will be as per standard design as below (use the text as mentioned in the ticket above. the figure is only to show how the info box looks)

image

atulgupta2024 commented 1 day ago

Enhance the CourtCase entity to add a new field for now - advocateCount. Store the value provided in the screen here, and use this for payment calculations.

this is for the hotfix. In the later sprint, when we take up the feature in more detail. we will update this as required.

aditiphadnis93 commented 1 day ago

@atulgupta2024 - the application fee should be conditional to the delay condonation application being there. Presently, that logic is not there in the payment calculator. Can we update that too?

mehulseg24 commented 1 day ago

Having noted the comment from Aditi on Delay condonation application fees, this request is SIGNED OFF!! To be Picked pu for development ASAP

atulgupta2024 commented 1 day ago

@aditiphadnis93 @mehulseg24 please explain the delay condonation and related application fees logic, so that we can see if this can also be done.

@devarajd94 are any masters created for payment processing?

@manimaarans to handle the payment logic via a master data, here's a table that we can create

ID Min_Count Max_Count Multiplier
1 1 3 1
2 4 null 3

to get the value from the table a SQL something like this will work (will need to modify based on our MDMS schema)

SELECT Multiplier 
FROM Calculation_Rules
WHERE count_value BETWEEN Min_Count AND COALESCE(Max_Count, count_value)
LIMIT 1;

it then be used as something like

count = 3;
welfare_fund = 25; //this can also come a master table 

// query for multiplier
final_welfare_fund_value = multiplier * welfare_fund ; 
aditiphadnis93 commented 1 day ago

In the payment calculator, the application fee should be applied only if the delay condonation application has been uploaded. Else it should be null. @mehulseg24 - please check.

atulgupta2024 commented 23 hours ago

@aditiphadnis93 the delay condonation fees part is already handled.

shambhavigoel1002 commented 23 hours ago

Hi @atulgupta2024 My doubt here is like for 1 advocated details are being added. ideally if count increases the details of all those also should be added . Let's say count is 3 and details will be only for 1 advocate ? cc:- @anirudh-0 @Ramu-kandimalla

atulgupta2024 commented 22 hours ago

@shambhavigoel1002 yes, those details are required, but that will happen later because there are other implications in terms of access right, primary secondary advocates, separate or duplicate vakalatnamas, vakalatnamas in case bundle, payments during join a case etc etc.

to keep things simple for hotfix, right now, we will do just a head count.