Support for React className

[mmcmm]

Hello, nice extension,

I installed it but it doesn't have any support (go to, completion) for react className, other than this looks good.

Thanks

[pucelle]

Thanks for your feedback, I will work on it in one or two days.

[pucelle]

Hi, mmcmm, I'm not a React user, can you provide some representative code pieces so I can add them to my test cases? Thanks.

[mmcmm]

Well in react when you set a class you need use className instead, nothing is different, just instead of class is className. Here it is the same thing in css peek https://github.com/pranaygp/vscode-css-peek/issues/3

render() { return <span className="menu navigation-menu">Menu</span> }

[pucelle]

https://github.com/pucelle/vscode-css-navigation/commit/13753d7755c189203ee6f25ca765ed8269355d9a This commit should fixed this.

Here is my test case: https://github.com/pucelle/vscode-css-navigation/commit/13753d7755c189203ee6f25ca765ed8269355d9a#diff-90f1f2b5e8f51bd56248f8d82ec15cec

[pucelle]

Sorry I'm new to GitHub, I'm trying to reference code pieces to show them here... And failed.

[pucelle]

OK, This time it should work. Here is my test case, please check if it can cover your scenarios. https://github.com/pucelle/vscode-css-navigation/blob/13753d7755c189203ee6f25ca765ed8269355d9a/client/test/fixture/index.jsx#L1-L7

[craigcosmo]

it does not work

import './home.scss'
class Home extends React.Component {
    render() {
        return (
                <div className="homeComponent">
                    <div className="menuwrapper" />
                </div>
        )
    }
}

.homeComponent {
    .menuwrapper {
    }
}

click go to definition won't go anywhere

[pucelle]

Hi, craigcosmo , can you provide you work directory info: What's your work space folder, and the file paths of your jsx and css file. Thanks.

[pucelle]

Otherwise to know what's happening, you can click Ctrl + Shift + U to open Output tab, then choose CSS Navigation, analysis the console logs, or just paste them here.

[craigcosmo]

I delete the extension and install again. its working now. Thanks for making this.