search

pucelle / vscode-css-navigation

Allowing Go to definition from HTML to CSS, or Find References from CSS to HTML.
https://marketplace.visualstudio.com/items?itemName=pucelle.vscode-css-navigation
MIT License
64 stars 8 forks source link

JSX className autocompletion #2

Closed mmcmm closed 5 years ago

mmcmm commented 5 years ago

This is a follow up #1 the "go to" works now, amazing, but the auto-completion doesn't seem to work, it works fine for .html files, better than the other "css classes auto-completion" extension, which was offering to many options.

Thanks again for the great extension.

pucelle commented 5 years ago

Thanks for your feedback. This seems to be a bug of VSCode, I researched on it and found the completion service failed at same places: <div c[CURSOR] /> - Here, the completion work. <div className="c[CURSOR]" /> - Here, the completion failed, No request send to language service. I will create an issue to VSCode.

pucelle commented 5 years ago

The issue I created:　https://github.com/Microsoft/vscode/issues/70616

pucelle commented 5 years ago

The issues was resolved, finally I found it's a functionality, not a BUG. The completion doesn't show by default in the tag attribute value of JSX.

you may change settings: "editor.quickSuggestions": { "other": true, "comments": false, "strings": false },

or click Ctrl + Space to popup completion list manually.

pucelle commented 5 years ago

I added some descriptions about this problem to my README.