pucelle / vscode-css-navigation

Allowing Go to definition from HTML to CSS, or Find References from CSS to HTML.
https://marketplace.visualstudio.com/items?itemName=pucelle.vscode-css-navigation
MIT License
66 stars 7 forks source link

Is this the same of ecmel.vscode-html-css extension or should be used togheter? #35

Closed gremo closed 4 years ago

gremo commented 4 years ago

Hi, I come into your extension following some GitHub issues/link.

I'm wondering in this extension should be used togheter with https://github.com/ecmel/vscode-html-css or is meant as a substitution. Thanks

pucelle commented 4 years ago

I didn't try this plugin, I think some functions should be same with my plugin, and you may meet some conflicts, like repeating results, but should no fatal mistakes.

My plugin having a customized core for parsing CSS files, so you may find it takes only few memory and much faster in searching, But normally you will not notice...

Never mind to give some suggestions if you find.

gremo commented 4 years ago

Thanks for helping. I'm just trying to understand how to setup things and get the job done!

Anyways, do you support heavly-mixin based SCSS files? Like this:

@each $breakpoint in map-keys($grid-breakpoints) {
  $infix: breakpoint-infix($breakpoint, $grid-breakpoints);

  .breaks#{$infix}-hide {
    @include media-breakpoint-up($breakpoint) {
      br { display: none; }
    }
  }
}

I'm wondering if the.breaks-md-hide will be detected/suggested?

pucelle commented 4 years ago

It's possible to do so in my SCSS parsing core, but I'm afraid it should affect the performance of the definitions searching.

This is a very good idea, and I'm also work with SCSS. After my work is not busy (I'v just started my new career as a graphic developer, that's really hard for me 😢), I will continue to extend this plugin, accept suggestions and ideas. Then I will do research on your idea.

Thanks.

gremo commented 4 years ago

Thanks for offering us such a good extension in your free time! I will close this issue an wait for updates!