search

pucelle / vscode-css-navigation

Allowing Go to definition from HTML to CSS, or Find References from CSS to HTML.
https://marketplace.visualstudio.com/items?itemName=pucelle.vscode-css-navigation
MIT License
64 stars 8 forks source link

1.10.1 disables some javascript snippets #46

Closed BrettBedarf closed 3 years ago

BrettBedarf commented 3 years ago

The past few days I've noticed some javascript snippets such as "for" to make a for loop stopped autocompleting or showing as a suggestion at all. When typing for + tab it just shows loading in the suggestion box:

image

While with CSS Navigation disabled, expected behavior, typing for in a js file, and autocomplete with tab:

image

I'm surprised this is the culprit but I've disabled all extensions and re-enabled one by one (not fun), quadruple checked, etc.

Also confirmed 1.10.0 manual install no snippet issues.

pucelle commented 3 years ago

Thanks for your feedback, I will check this later.

kanlukasz commented 3 years ago

@BrettBedarf, please provide more details. This will help to verify the problem more effectively

  1. What operating system are you working on?
  2. What version of VSCode are you using?
  3. Have you tried to reproduce this issue in a clean and fresh portable version of VSCode?
  4. Have you tried to reproduce this problem without any additional settings in your settings.json file?

I'm trying to reproduce this problem on a Windows 10 20H2 machine with WSL2 and everything seems to work fine: gif2

pucelle commented 3 years ago

1.10.0 have some issues and can't be started up... Sorry I tried to unpublish it but can't find a way. I checked but can't reproduce this issue too. I guess if vscode works well, this plugin should never affect another plugin's snippet function. Can you provide more infos as @kanlukasz said?

kanlukasz commented 3 years ago

Hmm ... it's strange, but just now, this problem also happened to me. Snippets didn't work Unfortunately I have not caught the cause yet.

Interestingly, at the same time, my virtual machine started using 95% of the CPU @pucelle do you use any regex pattern there or something like ripgrep? Maybe it's part of the problem, or maybe VSCode itself has a problem? Hmmm, I think it will be hard to verify

kanlukasz commented 3 years ago

There is definitely something wrong If i exclude JS from CSSNavigation.activeHTMLFileExtensions option, the snippet are starting to work

pucelle commented 3 years ago

Ok, I will check it.

pucelle commented 3 years ago

Found the bug in my code parsing classes, fixing it...

pucelle commented 3 years ago

V1.10.2 already released. please check it, thanks. Sorry I made a infinite loop in my CSS code lexical analyzer.

pucelle commented 3 years ago

Thanks again for both of your helps.