Extension does not work with notebook files (*.ipynb)

pucelle / vscode-run-on-save

Run configured shell commands when a file is saved in vscode, and output configured messages on status bar.

MIT License

50 stars 11 forks source link

Closed venaturum closed 2 years ago

venaturum commented 3 years ago

Looks like it may need to listen for event onDidSaveNotebookDocument ?

pucelle commented 3 years ago

Busy these days, will fix it soon.

venaturum commented 3 years ago

I know the feeling 😆

Thanks!

pucelle commented 3 years ago

Hi, venaturum, I checked the new vscode API at: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/vscode, but didn't find an API like onDidSaveNotebookDocument.

A similar API that's available is vscode.workspace.onDidCloseNotebookDocument, but I guess it can't work.

venaturum commented 3 years ago

My bad, looks like it's proposed API

pucelle commented 3 years ago

OK, I guess we should just leave this issue here and wait for the API released.

francisco-perez-sorrosal commented 3 years ago

I recently came up with the same problem and I created an issue in the VSCode github repo for that. Please upvote there!

pucelle commented 3 years ago

Voted

pucelle commented 2 years ago

Close it, never mind to reopen after everything is ready.